Opened on 03/14/2017 at 02:11:58 PM
Closed on 03/27/2017 at 08:05:27 AM
Last modified on 03/27/2017 at 08:09:34 AM
#4988 closed change (fixed)
[emscripten] Adjust API for Element Hiding Emulation filters
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #4122 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
#4394 introduced some changes in the way Element Hiding Emulation filters are represented in the API, these need to be reflected in the Emscripten-based classes as well.
What to change
- CSSPropertyFilter should be renamed into ElemHideEmulationFilter.
- Any filter containing the string [-abp-properties= is considered ElemHideEmulationFilter, no additional parsing should be performed.
- The error code for missing domain specialization is filter_elemhideemulation_nodomain now.
- ElemHideEmulationFilter.prototype.type should be elemhideemulation now. No further properties should be exposed compared to ElemHideBase.
Attachments (0)
Change History (6)
comment:1 Changed on 03/14/2017 at 02:45:00 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/27/2017 at 08:03:54 AM by abpbot
A commit referencing this issue has landed:
Issue 4988 - [emscripten Adjust API for Element Hiding Emulation filters]
comment:5 Changed on 03/27/2017 at 08:05:27 AM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 in reply to: ↑ 2 Changed on 03/27/2017 at 08:08:40 AM by trev
Replying to sergz:
no additional parsing should be performed.
Just wonder, who will parse it and how is it supposed to be used in this case?
Our content script is parsing them now, so we only do the parsing when actually necessary. But we still need to recognize them in core in order to know what to send to the content script.
Last edited on 03/27/2017 at 08:09:34 AM
by trev
Note: See
TracTickets for help on using
tickets.
Just wonder, who will parse it and how is it supposed to be used in this case?