Context Navigation

Opened on 03/15/2017 at 12:01:35 PM

Closed on 03/23/2017 at 05:13:34 AM

#4993 closed change (fixed)

Reported by:	kzar	Assignee:	kzar
Priority:	Unknown	Milestone:
Module:	Sitescripts	Keywords:
Cc:	trev, fhd, sebastian, greiner	Blocked By:	#3692
Blocking:		Platform:	Unknown / Cross platform
Ready:	no	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29384022

Currently our ESLint configuration uses the default settings for the operator-linebreak rule which turns out to be this:

"after", { "overrides": { "?": "before", ":": "before" } }

We want to apply the rule consistently for all operators, so our rule should look like this:

"operator-linebreak": ["error", "after"]

Some commits referencing this issue have landed:

You may use WikiFormatting here.

Change Properties

Summary:
Description:	You may use WikiFormatting here. === Background === Currently our ESLint configuration uses the default settings for the [http://eslint.org/docs/rules/operator-linebreak operator-linebreak] rule which turns out to be this: {{{ "after", { "overrides": { "?": "before", ":": "before" } } }}} === What to change === We want to apply the rule consistently for all operators, so our rule should look like this: {{{ "operator-linebreak": ["error", "after"] }}}
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):	https://codereview.adblockplus.org/29384022

Action

leave as closed .

reopen The resolution will be deleted. Next status will be 'reopened'.

reassign to The owner will be changed from kzar.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.