Opened on 03/15/2017 at 08:07:27 PM
Closed on 03/16/2017 at 07:27:38 PM
#4996 closed change (fixed)
Add .gitignore and adjust .hgignore
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P5 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.0 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently, we have a git mirror of adblockplussbrowser, but the project doesn't have a .gitignore file. Also is missing one rule for ignoring macOS .DS_Store files in .hgignore
What to change
Add a .gitignore file with all existing rules
Add a rule for ignoring .DS_Store files
Attachments (0)
Change History (5)
comment:1 Changed on 03/15/2017 at 08:22:19 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/16/2017 at 05:24:19 AM by asmirnov
comment:3 Changed on 03/16/2017 at 08:13:34 AM by fhd
It's possible to work with Git, just some extra hassle. You can work on patches against our GitHub mirrors, then import them into a Mercurial repo and push them to upstream. We do have a .gitignore in a number of repos, so that's fine.
comment:4 Changed on 03/16/2017 at 07:26:49 PM by abpbot
A commit referencing this issue has landed:
Issue 4996 - Add .gitignore and adjust .hgignore
comment:5 Changed on 03/16/2017 at 07:27:38 PM by diegocarloslima
- Milestone set to Adblock-Plus-for-Samsung-Browser-next
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I'd say we should have github -> mercurial repos synchronization too (i'd use git only and would be just happy).
So i believe github is just for cloning not for contributing.
Until it's not done i don't think it's worth it even though the efforts are extremely small.