Opened on 03/16/2017 at 01:02:56 PM
Closed on 04/19/2017 at 03:17:51 PM
#5002 closed defect (fixed)
WebRequest tests have potential concurrency issues.
| Reported by: | hfiguiere | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
From the post checkin review:
https://codereview.adblockplus.org/29377825/#msg19
I think we
should use some unique URL in test requests to distinguish them from another
requests sent from FilterEngine. May be we don't observe it on practice
currently but there is a race condition because the instance of MockWebRequest
is shared by all requests. BTW, there is also a data race on lastRequestHeaders
because the access to it is not synchronized.
Attachments (0)
Change History (3)
comment:1 Changed on 04/10/2017 at 12:41:48 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/19/2017 at 03:16:12 PM by abpbot
comment:3 Changed on 04/19/2017 at 03:17:51 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5002 - Fix potential concurrency issues in WebRequest tests.