Opened on 03/16/2017 at 09:10:58 PM
Closed on 06/01/2017 at 09:59:30 PM
Last modified on 06/20/2017 at 10:54:45 AM
#5005 closed change (fixed)
Always show the menu icon
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P5 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
Background
By default, Firefox hides the menu icon on devices that have a built in menu button.
What to change
Always show the menu icon, even if the device has a built in menu button. That way, the menu can be either accessed through the icon or through the hardware button.
Attachments (0)
Change History (4)
comment:1 Changed on 03/16/2017 at 09:59:23 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 06/01/2017 at 09:59:04 PM by abpbot
comment:3 Changed on 06/01/2017 at 09:59:30 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 06/20/2017 at 10:54:45 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
In the original issue, users were complaining from the following devices that, although they had a system menu, they still could not access the settings option for the browser. So, this test is based around those particular devices:
Huawei Ascend G700 (Android 4.2.1) -- Menu is shown.
Samsung Galaxy S4 (Android 4.4.2) -- Menu is shown.
Samsung Galaxy Core Plus (Android 4.2.2) -- Menu is shown.
Samsung Galaxy Note 3 (Android 5.0) -- Menu is shown.
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
A commit referencing this issue has landed:
Issue 5005 - Always show the menu icon