Opened on 03/22/2017 at 04:56:04 PM
Closed on 03/28/2017 at 01:51:28 PM
#5030 closed defect (fixed)
Fix the disposing order
Reported by: | sergz | Assignee: | |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Libadblockplus-Android | Keywords: | |
Cc: | asmirnov | Blocked By: | |
Blocking: | #5026 | Platform: | Unknown / Cross platform |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
It's about the function https://hg.adblockplus.org/libadblockplus-android/file/447a4bb3cb28/libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java#l158.
Firstly we should dispose objects which are using other objects, so, firstly FilterEngine and JsEngine and only afterwards their dependencies.
Attachments (0)
Change History (4)
comment:1 Changed on 03/23/2017 at 12:42:59 PM by sergz
- Cc asmirnov added; anton removed
comment:2 Changed on 03/28/2017 at 08:23:33 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 03/28/2017 at 01:50:50 PM by abpbot
comment:4 Changed on 03/28/2017 at 01:51:28 PM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5030 - Fix the disposing order