Opened on 03/28/2017 at 07:31:59 PM
Closed on 04/05/2017 at 11:10:31 AM
#5044 closed change (fixed)
Allow formmail2.py to use templates that are not located within sitescripts root directory
| Reported by: | kvas | Assignee: | kvas |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
#4377 created new form handler that has a configurable list of fields and configurable email template. However, because of the way templates are loaded, it's not possible to specify a template location outside of sitescripts root. Placing the configured template inside sitescripts is rather suboptimal because it might be automatically overwritten. It also violates the principle that configuration should be located separately from the code.
What to change
Allow specifying template location outside of sitescripts root in <name>.template variable in [formmail2] section. Relative paths should be resolved relative to sitescripts root for backwards compatibility but absolute paths should be resolved from filesystem root.
Attachments (0)
Change History (5)
comment:1 Changed on 03/28/2017 at 07:32:16 PM by kvas
- Priority changed from P3 to Unknown
- Ready unset
comment:2 Changed on 03/29/2017 at 12:02:32 PM by kvas
- Owner set to kvas
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 03/31/2017 at 04:53:54 PM by kvas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 04/05/2017 at 08:50:39 AM by abpbot
comment:5 Changed on 04/05/2017 at 11:10:31 AM by kvas
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 5044 - Support absolute paths for Jinja templates