Opened on 03/29/2017 at 09:53:57 AM

Closed on 03/29/2017 at 12:38:40 PM

#5049 closed change (fixed)

Allow embedded WebExtensions in gecko packager

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Automation Keywords:
Cc: wspee Blocked By:
Blocking: #5048 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29397581/

Description (last modified by trev)

Background

We need to add a WebExtension part to our current Adblock Plus for Firefox in order to migrate data.

What to change

Add webextension directory to the build if present. In that case, add <em:hasEmbeddedWebExtension>true</em:hasEmbeddedWebExtension> setting to install.rdf and start up WebExtension part in bootstrap.js. Modules of the legacy extension should be able to require("webextension") in order to get the promise returning a runtime.Port instance to communicate with the WebExtension part.

Attachments (0)

Change History (6)

comment:1 Changed on 03/29/2017 at 09:55:25 AM by trev

  • Description modified (diff)

comment:2 Changed on 03/29/2017 at 09:57:15 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 03/29/2017 at 09:57:57 AM by sebastian

  • Ready set

comment:4 Changed on 03/29/2017 at 10:24:36 AM by wspee

  • Cc wspee added

comment:5 Changed on 03/29/2017 at 12:38:09 PM by abpbot

A commit referencing this issue has landed:
Issue 5049 - Allow embedded WebExtensions in gecko packager

comment:6 Changed on 03/29/2017 at 12:38:40 PM by trev

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.