Opened on 03/29/2017 at 10:51:46 AM

Closed on 03/30/2017 at 04:48:31 PM

Last modified on 05/23/2017 at 02:31:48 PM

#5051 closed change (fixed)

Make sure that custom backups don't rely on FilterStorage's I/O

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.9-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By: #5052, #5271
Blocking: #5048 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29398708/

Description (last modified by trev)

Background

Creating and restoring custom backups will currently rely on FilterStorage's I/O

to read and write full backups. With the changes in #5050 it will no longer have file system access, so this functionality won't work.

What to change

Add custom code to filter-backup.js in order to read and write files, don't rely on default I/O.

What to test

This change affects the way patterns.ini file is being read and written. This includes:

  • Loading of filters on startup
  • Saving of filters on changes
  • Creation of automatic backups
  • Restoring of automatic backups from Filter Preferences
  • Creation of own backups (all filters and subscriptions) via Filter Preferences
  • Restoring of own backups (all filters and subscriptions) via Filter Preferences

Attachments (0)

Change History (7)

comment:1 Changed on 03/29/2017 at 11:12:36 AM by trev

  • Blocked By 5052 added

comment:2 Changed on 03/30/2017 at 12:21:08 PM by trev

  • Owner set to trev

comment:3 Changed on 03/30/2017 at 12:24:48 PM by trev

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing
  • Summary changed from Make sure that custom backups don't rely on io.js to Make sure that custom backups don't rely on FilterStorage's I/O

comment:4 Changed on 03/30/2017 at 04:46:01 PM by abpbot

A commit referencing this issue has landed:
​Issue 5051 - Make sure that custom backups don't rely on FilterStorage's I/O

comment:5 Changed on 03/30/2017 at 04:48:31 PM by trev

  • Description modified (diff)
  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 05/23/2017 at 11:50:54 AM by Ross

  • Blocked By 5271 added

comment:7 Changed on 05/23/2017 at 02:31:48 PM by Ross

  • Verified working set

Backup and restore is generally working okay except for the specific case of restoring an automatic backup from before upgrading (#5271).

ABP 2.8.2.4246-beta
Firefox 51 / 53 / Dev (54) / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.