Opened on 03/30/2017 at 04:57:21 PM
Closed on 04/05/2017 at 08:25:55 AM
Last modified on 10/08/2019 at 05:52:14 PM
#5074 closed change (fixed)
Fix tests for "is allowed connection"
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
According to #5066 that "is allowed connection" is used on a higher level, in particular only for subscription but current tests are based on a low level function WebRequest::GET which is working because of a hacky implementation in a hurry.
What to change
Use subscription API to cause a downloading of a subscription and to check the result of the operation (of course lower level API may be also used if there is a necessity).
Apparently it won't be possible to have complete tests until finishing with #5066 in adblockpluscore but even now it should get rid from checking of WebRequest::GET because there are plans to move the call of isAllowedConnection from WebRequest::GET to JS part, a bit closer to adblockpluscore to earlier satisfy requirements for it, e.g. it will be asynchronous.
Attachments (0)
Change History (4)
comment:1 Changed on 04/04/2017 at 10:52:26 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/05/2017 at 08:25:36 AM by abpbot
comment:3 Changed on 04/05/2017 at 08:25:55 AM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 08/22/2019 at 10:03:37 AM by zerathomaz
spam
A commit referencing this issue has landed:
Issue 5074 - fix tests for "is allowed connection"