Opened on 03/31/2017 at 01:00:20 PM

Closed on 04/03/2017 at 05:54:56 AM

#5081 closed change (fixed)

Make libadblockplus-android users supply the application and applicationVersion parameters

Reported by: fhd Assignee:
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Anton Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29399749/

Description

Background

Currently, libadblockplus-android sets all filter download request parameters to pretty much the exact same values used in ABP for Android. We should ask libadblockplus-android clients to supply at least the application and applicationVersion parameters. While at it, we should also set reasonable defaults for addonName and addonVersion.

What to change

  1. Require users of libadblockplus-android to pass in the application and applicationVersion parameters, and use these values for filter download requests.
  2. Change the hard coded parameter addonName to libadblockplus-android and addonVersion to 1.0. (At some point it should be possible to overwrite these from the libadblockplus-android client, but we still need better defaults than what we had before.)

Attachments (0)

Change History (6)

comment:1 Changed on 03/31/2017 at 01:00:44 PM by fhd

  • Ready set

comment:2 Changed on 03/31/2017 at 01:27:52 PM by asmirnov

  • Ready unset 
D/WebRequest: Downloading from: https://easylist-downloads.adblockplus.org/exceptionrules.txt?addonName=libadblockplus-android&addonVersion=1.0&application=org.adblockplus.libadblockplus.android.webviewapp&applicationVersion=app.version&platform=libadblockplus&platformVersion=1.0&lastVersion=201703301411&downloadCount=1
D/WebRequest: Downloading from: https://easylist-downloads.adblockplus.org/easylist.txt?addonName=libadblockplus-android&addonVersion=1.0&application=org.adblockplus.libadblockplus.android.webviewapp&applicationVersion=app.version&platform=libadblockplus&platformVersion=1.0&lastVersion=0&downloadCount=1
D/WebRequest: Downloading finished
D/WebRequest: Downloading finished
D/IsAllowedConnectionCallbackImpl: Checking connection: null
D/WebRequest: Downloading from: https://notification.adblockplus.org/notification.json?addonName=libadblockplus-android&addonVersion=1.0&application=org.adblockplus.libadblockplus.android.webviewapp&applicationVersion=app.version&platform=libadblockplus&platformVersion=1.0&lastVersion=0&downloadCount=0
D/WebRequest: Downloading finished

comment:3 Changed on 03/31/2017 at 01:30:42 PM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 03/31/2017 at 01:33:06 PM by asmirnov

i had to skip generating version as previously - we need hardcoded value

comment:5 Changed on 03/31/2017 at 03:13:48 PM by abpbot

A commit referencing this issue has landed:
​Issue 5081 - Make libadblockplus-android users supply the application and applicationVersion parameters

comment:6 Changed on 04/03/2017 at 05:54:56 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.