Opened on 04/03/2017 at 04:39:15 AM
Closed on 04/08/2017 at 07:38:21 AM
#5086 closed change (fixed)
Add webrtc connection type
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | trev, sebastian | Blocked By: | |
| Blocking: | #5087 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29401571/ |
||
Description
Background
In #4455 we are hoping to support WebRTC blocking by wrapping the relevant APIs like we do for the WebSocket ones. Before we can do that we need to add a new request type for them.
What to change
Add the webrtc request type to the core code. Ensure the tests all still pass.
Attachments (0)
Change History (11)
comment:1 Changed on 04/03/2017 at 04:41:27 AM by kzar
- Blocking 5087 added
comment:2 Changed on 04/03/2017 at 08:54:50 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 04/03/2017 at 10:48:59 AM by kzar
- Blocking 5091 added
comment:4 Changed on 04/04/2017 at 01:18:24 PM by trev
- Priority changed from Unknown to P3
- Ready set
comment:6 Changed on 04/05/2017 at 12:20:58 PM by abpbot
comment:7 Changed on 04/07/2017 at 01:13:10 PM by kzar
- Blocking 5091 removed
comment:8 Changed on 04/07/2017 at 01:23:49 PM by kzar
- Blocking 5124 added
comment:9 Changed on 04/07/2017 at 01:24:56 PM by kzar
- Blocking 5124 removed
comment:10 Changed on 04/08/2017 at 07:37:54 AM by abpbot
A commit referencing this issue has landed:
Issue 5086 - Add webrtc request type
comment:11 Changed on 04/08/2017 at 07:38:21 AM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5086 - Add webrtc connection type