Opened on 04/03/2017 at 06:03:27 AM

Closed on 04/28/2017 at 10:24:14 AM

#5088 closed change (fixed)

Remove code duplicate for refresh subscriptions

Reported by: asmirnov Assignee:
Priority: P4 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29401555/

Description

Background

Right after preloading of subscriptions files (#5010) we do force subscriptions to update/refresh. And the refresh code is unintentionally duplicated, see refreshSubscriptions() method and forceUpdateRunnable.

What to change

Just use refreshSubscriptions instead of forceUpdateRunnable.run().

Attachments (0)

Change History (5)

comment:1 Changed on 04/03/2017 at 06:10:11 AM by asmirnov

  • Summary changed from Remove code duplicate for updating subscriptions to Remove code duplicate for refresh subscriptions

comment:2 Changed on 04/03/2017 at 06:10:38 AM by asmirnov

  • Priority changed from P5 to P4

comment:3 Changed on 04/03/2017 at 06:18:07 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/28/2017 at 10:22:05 AM by abpbot

A commit referencing this issue has landed:
​Issue 5088 - Remove code duplicate for refresh subscriptions

comment:5 Changed on 04/28/2017 at 10:24:14 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.