Opened on 04/04/2017 at 07:05:11 PM

Closed on 02/26/2018 at 09:41:28 AM

Last modified on 03/26/2018 at 10:00:57 PM

#5103 closed change (incomplete)

Add padding to 1/2 column images on acceptableads.com

Reported by: juliandoucette Assignee:
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: athornburgh, jeen, saroyanm, p.pastourmatzis Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

There are a couple images on acceptableads.com that look awkwardly wide.

What to change

Add a little padding around these images.

Attachments (0)

Change History (10)

comment:1 Changed on 04/04/2017 at 07:05:46 PM by juliandoucette

I can do this myself if product approves.

comment:2 Changed on 04/12/2017 at 03:37:36 PM by jeen

@juliandoucette I am not sure I understand what you mean by this? Are the images too large or the padding too wide?

comment:3 Changed on 04/12/2017 at 03:49:03 PM by juliandoucette

@Jeen there is not enough padding left/right around these images. As a result (especially in example 2) the images appear too large IMO.

comment:4 Changed on 04/13/2017 at 11:06:45 AM by jeen

@juliandoucette ah got you. Yes happy for you to go ahead and adjust the padding accordingly.

comment:5 Changed on 04/13/2017 at 12:20:15 PM by juliandoucette

  • Priority changed from Unknown to P3
  • Ready set

comment:6 Changed on 09/01/2017 at 01:31:28 PM by juliandoucette

  • Milestone acceptableads.com/committee cleanup deleted

comment:7 Changed on 09/05/2017 at 12:52:34 PM by juliandoucette

  • Owner set to juliandoucette

comment:8 Changed on 09/12/2017 at 01:28:21 PM by juliandoucette

  • Owner juliandoucette deleted

I would have unset codereview and removed ​this link if I added it in the first place.

comment:9 Changed on 02/26/2018 at 09:41:28 AM by juliandoucette

  • Resolution set to incomplete
  • Status changed from new to closed

Migrated to ​https://gitlab.com/eyeo/web.acceptableads.com/issues/3

comment:10 Changed on 03/26/2018 at 10:00:57 PM by abpbot

Some commits referencing this issue have landed:

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.