Opened on 04/06/2017 at 03:52:40 PM
Closed on 06/02/2017 at 06:50:16 AM
#5119 closed change (fixed)
use own version of buildtools for ensure_deps instead of a version from adblockpluscore
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | fhd | Blocked By: | |
| Blocking: | #4907 | Platform: | Unknown / Cross platform |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sergz)
Background
In order to update v8 (#4907) we need to fix ensure_dependencies.py (#4906), however it won't be easy to also update adblockpluscore because the latter contains some incompatible changes and it would be better to not mix adaptation to these changes with updating of v8 which is already going to be not a small change. So the plan is to land #4906, then this issue, then #4907 and only afterwards update adblockpluscore.
What to change
Change dependencies file.
The changes concerning ensure_dependencies.py imported by this are:
changes without issues:
| e120a0d93303 | Noissue - Adapt quotes for compliance with our coding style | Sebastian Noack |
| 0a21b061b2fb | Noissue - Got rid of non-defualt script encodings | Sebastian Noack |
Attachments (0)
Change History (6)
comment:1 Changed on 06/01/2017 at 04:13:25 PM by sergz
- Blocking 4907 added
- Owner set to sergz
comment:3 Changed on 06/01/2017 at 04:57:00 PM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 06/02/2017 at 06:48:23 AM by abpbot
A commit referencing this issue has landed:
Issue 5119 - use own version of buildtools for ensure_dependencies.py instead of one from adblockpluscore
comment:6 Changed on 06/02/2017 at 06:50:16 AM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
It also implies updating of ensure_dependencies.py file, so I'm adding a list of relevant changes in buildtools repository since the commit referenced by adblockpluscore which is referenced by libadblockplus.