Opened on 04/11/2017 at 07:59:21 AM

Closed on 04/12/2017 at 08:30:02 AM

#5125 closed change (fixed)

Fix prefs tests to comply with new v8

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: Blocked By:
Blocking: #4907 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29409558/

Description

Background

Tests fail when we create a second instance of FilterEngine on the same instance of JsEngine because new version of v8 honors const in JavaScript and in compat.js there are such statements like const Cc.

What to change

Don't use the same instance of JsEngine for more than one instance of FilterEngine in PrefsTest.

Attachments (0)

Change History (3)

comment:1 Changed on 04/11/2017 at 08:13:18 AM by sergz

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/12/2017 at 08:29:31 AM by abpbot

A commit referencing this issue has landed:
​Issue 5125 - Fix prefs tests to comply with new v8

comment:3 Changed on 04/12/2017 at 08:30:02 AM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.