Opened on 04/14/2017 at 08:13:50 PM
Closed on 01/30/2018 at 05:59:36 PM
#5143 closed change (fixed)
[emscripten] Convert element hiding emulation container to C++
| Reported by: | trev | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | oleksandr | Blocked By: | |
| Blocking: | #4122, #5144 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
See #4122 for the rationale. For maximal performance, all operations involving filter text should stay within Emscripten - including elemHideEmulation container.
What to change
- Implement ElemHideEmulation namespace (alternatively: class with default instance, like in #5141) exposing methods clear, add and remove to manage list of filters.
- Implement getRulesForDomain method returning _ElemHideEmulation_FilterList object. This object should expose a filterCount property as well as filterAt method.
Attachments (0)
Change History (6)
comment:1 Changed on 04/15/2017 at 08:25:56 AM by trev
- Blocking 5144 added
comment:2 Changed on 10/19/2017 at 09:54:33 AM by oleksandr
- Cc oleksandr added
comment:3 Changed on 10/27/2017 at 04:42:07 PM by hfiguiere
- Owner set to hfiguiere
comment:4 Changed on 11/01/2017 at 02:44:48 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 01/30/2018 at 05:58:36 PM by abpbot
comment:6 Changed on 01/30/2018 at 05:59:36 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5143 - Convert ElemHideEmulation to C++