Opened on 04/15/2017 at 01:52:52 PM

Closed on 05/10/2017 at 07:21:44 AM

#5145 closed change (fixed)

Add test for IsAllowedConnectionCallbackImpl

Reported by: asmirnov Assignee:
Priority: P4 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29413555/

Description

Background

In order to control code quality it's better to have it tests covered. We need to add test for IsAllowedConnectionCallbackImpl class.

What to change

Add Android instrumentation test for IsAllowedConnectionCallbackImpl class.

Attachments (0)

Change History (3)

comment:1 Changed on 04/15/2017 at 01:58:18 PM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 05/10/2017 at 07:21:08 AM by abpbot

A commit referencing this issue has landed:
​Issue 5145 - Add test for IsAllowedConnectionCallbackImpl

comment:3 Changed on 05/10/2017 at 07:21:44 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.