Opened on 04/21/2017 at 06:50:56 AM

Closed on 05/10/2017 at 07:15:06 AM

#5167 closed change (fixed)

Update to use libadblockplus revision dca8df9af1a7

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz Blocked By:
Blocking: #5205 Platform: Android
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29421687/
https://codereview.adblockplus.org/29429555/

Description

Background

There were some significant changes in API (method signatures) so libadblockplus-android should be updated.

What to change

Native glue classes should use new API.

Attachments (0)

Change History (10)

comment:1 Changed on 04/25/2017 at 12:13:01 PM by asmirnov

After code review with Sergey we've found some changes should be done in libadblockplus, so updating to 2b0c6fd016be is required now

comment:2 Changed on 04/25/2017 at 12:13:15 PM by asmirnov

  • Summary changed from Update to use libadblockplus rev. 91a56535914c to Update to use libadblockplus rev. 2b0c6fd016be

comment:3 Changed on 04/25/2017 at 12:15:34 PM by asmirnov

  • Review URL(s) modified (diff)

comment:4 Changed on 04/25/2017 at 01:17:25 PM by asmirnov

  • Review URL(s) modified (diff)

comment:5 Changed on 04/25/2017 at 01:28:34 PM by asmirnov

  • Summary changed from Update to use libadblockplus rev. 2b0c6fd016be to Update to use libadblockplus revision 2b0c6fd016be

comment:6 Changed on 05/03/2017 at 12:52:34 PM by asmirnov

  • Blocking 5205 added

comment:7 Changed on 05/05/2017 at 11:29:57 AM by asmirnov

  • Summary changed from Update to use libadblockplus revision 2b0c6fd016be to Update to use libadblockplus revision dca8df9af1a7

comment:8 Changed on 05/05/2017 at 11:30:30 AM by asmirnov

  • Review URL(s) modified (diff)

comment:9 Changed on 05/10/2017 at 07:14:13 AM by abpbot

A commit referencing this issue has landed:
Issue 5167 - Update to use libadblockplus revision dca8df9af1a7

comment:10 Changed on 05/10/2017 at 07:15:06 AM by asmirnov

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.