Opened on 04/21/2017 at 11:58:06 AM
Closed on 07/03/2017 at 04:18:30 PM
#5169 closed change (fixed)
Implement "Whitelisted Websites" tab for new options page
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | wspee, greiner | Blocked By: | |
| Blocking: | #5158 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by saroyanm)
Background
After several design iterations we finally have a final version of the new options page (See #5158).
What to change
Implement "Whitelisted Websites" tab as specified in the Options Page Specification.
Attachments (0)
Change History (9)
comment:2 Changed on 04/21/2017 at 12:04:44 PM by saroyanm
comment:3 follow-up: ↓ 5 Changed on 04/21/2017 at 12:12:25 PM by saroyanm
- Description modified (diff)
Updated link to reflect final revision, not master. @Winsley let me know if you think this should be reverted.
comment:4 Changed on 04/21/2017 at 03:27:46 PM by greiner
- Component changed from Unknown to User-Interface
- Priority changed from Unknown to P2
- Ready set
comment:5 in reply to: ↑ 3 Changed on 04/21/2017 at 03:46:37 PM by wspee
Replying to saroyanm:
Updated link to reflect final revision, not master. @Winsley let me know if you think this should be reverted.
Link's to the specification should always be to a specific version so they don't change auto magically. Your link also links to the correct section, so IMHO it's fine.
comment:6 Changed on 06/19/2017 at 09:04:01 AM by saroyanm
- Owner set to saroyanm
comment:7 Changed on 07/03/2017 at 04:15:48 PM by abpbot
A commit referencing this issue has landed:
Issue 5169 - added HTML, strings and functionality of Whitelist tab
comment:8 Changed on 07/03/2017 at 04:18:03 PM by saroyanm
For styles implementation I think make sense to create separate issue, while most of them will be global and apply to different issues as well.
comment:9 Changed on 07/03/2017 at 04:18:30 PM by saroyanm
- Resolution set to fixed
- Status changed from new to closed
See comment above
@Winsley please let me know if the links to specs looks fine to you.
@Thomas please make the issue ready as soon you think it is.