Opened on 05/19/2014 at 07:42:40 AM

Closed on 07/11/2014 at 08:18:32 AM

#517 closed change (fixed)

[Typed objects] Make unit tests compatible with Chrome and Safari

Reported by: trev Assignee: trev
Priority: P2 Milestone:
Module: Core Keywords:
Cc: Blocked By: #427, #516
Blocking: #145 Platform: Chrome
Ready: yes Confidential: no
Tester: Verified working: no
Review URL(s):

​http://codereview.adblockplus.org/5090313282519040/

Description

Background

The typed objects code files are using syntax that is currently only supported by Firefox. Consequently, the unit tests fail in Chrome.

What to change

Automatically run JSHydra when the unit tests run in a browser not supporting JavaScript 1.7 in order to convert the Firefox-specific syntax.

Attachments (0)

Change History (3)

comment:1 Changed on 05/19/2014 at 07:53:03 AM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 07/09/2014 at 12:38:11 PM by philll

  • Platform set to Firefox

comment:3 Changed on 07/11/2014 at 08:18:32 AM by trev

  • Platform changed from Firefox to Chrome
  • Resolution set to fixed
  • Status changed from reviewing to closed

Fixed: ​https://hg.adblockplus.org/adblockpluscore/rev/f3ba44eaaccc

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.