Opened on 04/24/2017 at 08:13:22 AM

Closed on 04/28/2017 at 02:57:58 PM

Last modified on 06/01/2017 at 07:23:59 AM

#5173 closed defect (fixed)

ABP Samsung Internet fails to initialise on Android 5.0.1

Reported by: scheer Assignee: diegocarloslima
Priority: P2 Milestone: Adblock-Plus-for-Samsung-Browser-1.1.0
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: vickyyu, diegocarloslima Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Scheer Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29422622/

Description

When trying to launch ABP for Samsung Internet, the app loads, but fails to initialise and then crashes to the home screen.

This issue is not experienced on Android 7.0 (Galaxy S7)

Environment

adblockplussbrowser-1.1.0-signed-zipaligned
Galaxy S4
Android 5.0.1

How to reproduce

  1. Launch ABP Samsung Internet

Observed behaviour

The app attempts to initialise, but crashes to home screen.

Expected behaviour

The app initialises correctly.

Attachments (1)

Galaxy S4 Android 5.0.1 Sbrowser 1.1.0.txt​ (76.5 KB) - added by scheer on 04/24/2017 at 08:13:36 AM.

Download all attachments as: .zip

Change History (9)

Changed on 04/24/2017 at 08:13:36 AM by scheer

comment:1 Changed on 04/26/2017 at 01:53:35 PM by diegocarloslima

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next
  • Owner set to diegocarloslima
  • Priority changed from Unknown to P2
  • Ready set

comment:2 Changed on 04/26/2017 at 01:54:38 PM by diegocarloslima

This issue was due an inconsistency in UrlInputOpenerPreference.setIcon() which would result in a StackOverflowError on devices running Android 5.

comment:3 Changed on 04/26/2017 at 01:58:36 PM by diegocarloslima

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/27/2017 at 07:50:45 AM by scheer

  • Verified working set
  • The app now correctly initialises on Android 5.0.

adblockplussbrowser-1.1.0-testfix-signed-zipaligned
Galaxy S4
Android 5.0.1

comment:5 Changed on 04/28/2017 at 02:52:05 PM by abpbot

A commit referencing this issue has landed:
​Issue 5173 - ABP Samsung Internet fails to initialise on Android 5.0.1

comment:6 Changed on 04/28/2017 at 02:57:58 PM by diegocarloslima

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 05/26/2017 at 08:13:55 PM by diegocarloslima

  • Milestone Adblock-Plus-for-Samsung-Browser-next deleted

This was released on 1.1.0

comment:8 Changed on 06/01/2017 at 07:23:59 AM by mario

  • Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.0

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from diegocarloslima.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.