Opened on 04/25/2017 at 12:21:30 PM
Closed on 05/21/2017 at 09:04:52 PM
Last modified on 07/07/2017 at 11:23:31 AM
#5184 closed change (fixed)
Support additional webRequest types reported by Firefox
| Reported by: | trev | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.13.3-for-Chrome-Opera |
| Module: | Platform | Keywords: | |
| Cc: | mjethani | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
See https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/webRequest/ResourceType - the types reported by webRequest in Firefox aren't the same ones that Chrome supports. In particular, "xbl", "xslt", "beacon", "xml_dtd", "imageset", "web_manifest" are new.
What to change
Make sure that "xbl", "xslt", "xml_dtd", "web_manifest" are treated the same as "other." Make sure that "beacon" is treated same as "ping" and "imageset" same as "image" - this is the aliasing used by the legacy Firefox extension.
Hints for testers
This change should not have any visible effect on Chrome. In order to make sure that it doesn't, you can check the resource types reported in the devtools panel.
Attachments (0)
Change History (8)
comment:1 Changed on 04/25/2017 at 12:23:54 PM by sebastian
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 04/25/2017 at 01:12:03 PM by mjethani
comment:3 Changed on 04/25/2017 at 01:13:49 PM by mjethani
- Owner set to mjethani
comment:4 Changed on 04/25/2017 at 04:29:43 PM by mjethani
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 05/21/2017 at 08:58:12 PM by abpbot
A commit referencing this issue has landed:
Issue 5184 - Support Firefox-specific webRequest types
comment:6 Changed on 05/21/2017 at 09:04:52 PM by mjethani
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 06/21/2017 at 10:44:55 AM by sebastian
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
comment:8 Changed on 07/07/2017 at 11:23:31 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
The following resource types are confirmed supported in Firefox 53:
I did not check the following types since we probably don't care about these:
Service workers, while not reported in Chrome at all, are reported as script in Firefox.