Opened on 04/28/2017 at 08:11:56 AM
Last modified on 04/28/2017 at 02:37:56 PM
#5197 new change
Add FilterEngine::SetSubscriptionrChangeCallback
| Reported by: | sergz | Assignee: | |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | asmirnov | Blocked By: | #5123, #5123, #5196 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Currently we receive all kind of notifications in FilterEngine::SetFilterChangeCallback as event (e.g. subscription.disabled) and JsValue&& object, however the user of libadblockplus for the above example should rather receive ("disabled", Subscription&&). Therefore we need to differentiate events from different sources, namely filter, subscription and others and pass a concrete object (Filter&& for filter and Subscription&& for subscription) instead of JsValue. So, since the signature for FilterEngine::SetFilterChangeCallback will be also changed it will force the users to adapt the code (if not now then later after not exposing JsValue from Filter), meanwhile to still provide them with the ability to get other events we need to add some way like FilterEngine::SetGenericEventCallback.
Attachments (0)
Change History (7)
comment:1 Changed on 04/28/2017 at 08:12:33 AM by sergz
- Blocking 5123, 5196 added
comment:2 Changed on 04/28/2017 at 08:12:49 AM by sergz
- Blocked By 5123, 5196 added
- Blocking 5123, 5196 removed
comment:3 Changed on 04/28/2017 at 08:13:56 AM by sergz
- Blocked By 5123, 5196 removed
comment:4 Changed on 04/28/2017 at 08:14:22 AM by sergz
- Blocked By 5123, 5196 added
comment:5 Changed on 04/28/2017 at 08:14:48 AM by sergz
- Blocked By 5123, 5196 removed
comment:6 Changed on 04/28/2017 at 08:17:25 AM by sergz
- Blocked By 5123, 5196 added
comment:7 Changed on 04/28/2017 at 02:37:56 PM by abpbot
- Blocked By
