Opened on 05/05/2017 at 09:20:16 AM
Closed on 05/25/2017 at 08:35:29 AM
Last modified on 06/19/2017 at 08:58:03 AM
#5213 closed defect (fixed)
[HA Crash] Race conditions in class NSCacheResolver
| Reported by: | jand | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Browser-for-iOS-1.5.3 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | mario, scheer | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | no | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by mario)
Environment
All devices and all iOS version are affected. Application version is 1.5.2.
How to reproduce
Application is crashing probably in unpredictable use cases. Those crashes are caused by race conditions, they are hard to reproduce.
Observed behaviour
HA contains several types of crash reports:
https://rink.hockeyapp.net/manage/apps/310687/app_versions/28/crash_reasons/167707737
https://rink.hockeyapp.net/manage/apps/310687/app_versions/28/crash_reasons/167677404
https://rink.hockeyapp.net/manage/apps/310687/app_versions/28/crash_reasons/167677241
https://rink.hockeyapp.net/manage/apps/310687/app_versions/28/crash_reasons/167708102
Expected behaviour
Application should not be crashing.
Hint for testers
The implementation of this issue changes one particular class, which is responsible for resolving the right content type of downloaded resources (whatever it is: script, image or html). Other parts of the browser have not been changed significantly. Acceptable ads is the only feature which might be affected by the implementation of this fix.
Attachments (0)
Change History (6)
comment:1 Changed on 05/09/2017 at 06:22:37 PM by jand
- Platform changed from Unknown / Cross platform to Adblock Browser for iOS
comment:2 Changed on 05/10/2017 at 02:20:09 PM by mario
- Cc mario added
comment:3 Changed on 05/25/2017 at 08:35:29 AM by jand
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 06/19/2017 at 08:40:19 AM by jand
comment:5 Changed on 06/19/2017 at 08:54:51 AM by mario
- Cc scheer added
- Description modified (diff)
Added jand's explanation to the ticket.
comment:6 Changed on 06/19/2017 at 08:58:03 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- As AA has already been run on this, as well as normal functionality testing on AA, I would deem this as verified.
What has been changed:
The implementation of this issue changes one particular class, which is responsible for resolving right content type of downloaded resource (whatever it is script, image or html). Other parts of browser has not been changes significantly. Acceptable ads is only browser feature which might be affected by implementation of this feature.