Opened on 05/05/2017 at 03:43:22 PM
Closed on 05/10/2017 at 03:22:24 PM
Last modified on 05/12/2017 at 09:21:27 AM
#5215 closed change (fixed)
[ABP for Samsung Internet] - Inconsistent string needs updating
| Reported by: | Shikitita | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.0 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | diegocarloslima, lisabielik, vickyyu, mario | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
Background
A string currently used for ABP for Samsung Internet needs changing due to consistency reasons
What to change
"Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the Allow some nonintrusive ads option."
should be changed to
"Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the Allow some nonintrusive advertising option."
Attachments (3)
Change History (15)
comment:1 Changed on 05/08/2017 at 09:22:06 PM by diegocarloslima
- Owner diegocarloslima deleted
- Ready set
comment:2 follow-up: ↓ 6 Changed on 05/09/2017 at 10:04:41 AM by scheer
- In addition to the above, 'Acceptable Ads' is still displayed as a title in the main settings screen of ABP. Although the select box name is correctly displayed as 'Allow some nonintrusive advertising', the title is 'Acceptable Ads'. I guess, for consistency, this needs to also be changed?
Changed on 05/09/2017 at 12:45:32 PM by mario
Changed on 05/09/2017 at 12:45:38 PM by mario
Changed on 05/09/2017 at 12:45:44 PM by mario
comment:3 Changed on 05/09/2017 at 01:18:51 PM by jwangenheim
- Owner set to jwangenheim
comment:4 Changed on 05/09/2017 at 01:19:38 PM by mario
I accidentally added three screenshots to the wrong ticket. Please ignore until removed.
comment:5 Changed on 05/09/2017 at 01:47:55 PM by jwangenheim
- Blocked By 5193 added
comment:6 in reply to: ↑ 2 Changed on 05/09/2017 at 02:09:46 PM by Shikitita
Replying to scheer:
- In addition to the above, 'Acceptable Ads' is still displayed as a title in the main settings screen of ABP. Although the select box name is correctly displayed as 'Allow some nonintrusive advertising', the title is 'Acceptable Ads'. I guess, for consistency, this needs to also be changed?
Not necessarily. ABB and ABP for iOS have a section named "Acceptable Ads" which, after tapping on it, displays the option "Allow some nonintrusive advertising", that you can then enable or disable, and also an explanation of what Acceptable Ads is/means. Most of our users should know, by now, about our "Acceptable Ads" initiative, therefore having it as a title makes sense and also keeps consistency across most of our products.
comment:7 Changed on 05/10/2017 at 12:09:23 PM by jwangenheim
- Blocked By 5193 removed
comment:8 Changed on 05/10/2017 at 02:05:10 PM by jwangenheim
- Status changed from new to reviewing
comment:10 Changed on 05/10/2017 at 03:18:23 PM by abpbot
A commit referencing this issue has landed:
Issue 5215 - Inconsistent string needs updating
comment:11 Changed on 05/10/2017 at 03:22:24 PM by jwangenheim
- Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.0
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 05/12/2017 at 09:21:27 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- The correct text now reads:
"Annoying ads are always blocked, while nonintrusive ads are displayed by default. You can change this setting at any time by tapping the Allow some nonintrusive advertising option."
adblockplussbrowser-release-signed-2
Galaxy S7
Android 7.0
