Opened on 05/10/2017 at 03:09:50 PM
Closed on 05/18/2017 at 05:54:43 PM
Last modified on 05/18/2017 at 05:59:59 PM
#5230 closed defect (fixed)
Browser tests don't work on macOS
Reported by: | fhd | Assignee: | hfiguiere |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Core | Keywords: | |
Cc: | hfiguiere | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | yes |
Review URL(s): |
Description
Environment
- macOS 10.12.4
- adblockpluscore revision e7313a8e2340
How to reproduce
- Clone the adblockpluscore repository
- Run npm install
- Run npm test test/browser
Observed behaviour
I get an error message:
> adblockpluscore@ test /path/to/adblockpluscore > node test_runner.js "test/browser" Failed running browser tests { Error: Command failed: /path/to/adblockpluscore/chromium-snapshots/chromium-darwin-467222/chrome-mac/Chromium.app/Contents/MacOS/Chromium --headless --single-process --disable-gpu --no-sandbox --allow-file-access-from-files --remote-debugging-port=9222 --user-data-dir=/var/folders/99/xkdrs9594b71hk4xn0ccw9dm0000gn/T/chromium-dataqF7mwB dlopen /path/to/adblockpluscore/chromium-snapshots/chromium-darwin-467222/chrome-mac/Chromium.app/Contents/MacOS/../Versions/60.0.3082.0/Chromium Framework.framework/Chromium Framework: dlopen(/path/to/adblockpluscore/chromium-snapshots/chromium-darwin-467222/chrome-mac/Chromium.app/Contents/MacOS/../Versions/60.0.3082.0/Chromium Framework.framework/Chromium Framework, 261): image not found at ChildProcess.exithandler (child_process.js:205:12) at emitTwo (events.js:106:13) at ChildProcess.emit (events.js:194:7) at maybeClose (internal/child_process.js:899:16) at Socket.<anonymous> (internal/child_process.js:342:11) at emitOne (events.js:96:13) at Socket.emit (events.js:191:7) at Pipe._handle.close [as _onclose] (net.js:511:12) killed: false, code: null, signal: 'SIGABRT', cmd: '/path/to/adblockpluscore/chromium-snapshots/chromium-darwin-467222/chrome-mac/Chromium.app/Contents/MacOS/Chromium --headless --single-process --disable-gpu --no-sandbox --allow-file-access-from-files --remote-debugging-port=9222 --user-data-dir=/var/folders/99/xkdrs9594b71hk4xn0ccw9dm0000gn/T/chromium-dataqF7mwB' }
(Paths changed.)
Expected behaviour
The tests should run.
Attachments (0)
Change History (7)
comment:1 Changed on 05/10/2017 at 03:24:00 PM by hfiguiere
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/10/2017 at 03:25:43 PM by hfiguiere
- Owner set to hfiguiere
comment:3 Changed on 05/18/2017 at 05:52:41 PM by abpbot
comment:4 Changed on 05/18/2017 at 05:54:01 PM by abpbot
A commit referencing this issue has landed:
Issue 5230 - Properly download Chromium on macOS
comment:5 Changed on 05/18/2017 at 05:54:43 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 05/18/2017 at 05:59:59 PM by fhd
- Priority changed from Unknown to P3
- Ready set
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 5230 - Properly download Chromium on macOS