Opened on 05/12/2017 at 11:07:07 AM
Closed on 08/15/2017 at 11:42:47 AM
Last modified on 09/17/2017 at 05:01:26 PM
#5237 closed defect (fixed)
Correct filter lists not applied on other language installation
| Reported by: | scheer | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.2 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | diegocarloslima, jwangenheim, tpregueiro, mario | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by jwangenheim)
When the user installs ABP for Samsung Internet in any other language other than English, the correct corresponding language filter list should be applied (and not just the default English filter list).
Environment
adblockplussbrowser-release-signed-2
Galaxy S7
Android 7.0
How to reproduce
- Change device language to French
- Install ABP for Samsung Internet
Observed behaviour
English language filter list is applied.
Expected behaviour
French language filter list is applied.
If the user starts the app for the first time, we force to update the subscription which was selected as the default, no matter if he has a WIFI connection or not. From the second start we only update when the user has a WIFI connection.
To make sure the users have at least one working filter list after they installed the app, we keep the bundled EasyList. If the download fails or English is selected as default, the bundled list will be used.
We'll need to mach the prefixes attr in subscriptions.xml with the current Locale, on first launch, in order to select the most appropriate filter list. If no match is found, it should default to easylist. It might be required to tweak with the codes for proper mapping (e.g. Hebrew code is he in subscriptions.xml while the Android locale code is iw).
Attachments (0)
Change History (14)
comment:1 Changed on 05/23/2017 at 03:03:54 PM by diegocarloslima
- Description modified (diff)
- Priority changed from Unknown to P2
- Ready set
comment:2 Changed on 08/02/2017 at 02:50:59 PM by jwangenheim
- Owner set to jwangenheim
comment:3 Changed on 08/03/2017 at 07:24:03 AM by jwangenheim
- Milestone set to Adblock-Plus-for-Samsung-Browser-next
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/03/2017 at 07:30:03 AM by jwangenheim
- Review URL(s) modified (diff)
- Status changed from reviewing to reopened
comment:5 Changed on 08/03/2017 at 08:19:48 AM by jwangenheim
comment:6 Changed on 08/03/2017 at 08:21:03 AM by jwangenheim
- Cc LawannaURR tpregueiro added; mario removed
comment:7 Changed on 08/03/2017 at 08:21:33 AM by mario
- Cc mario added
comment:8 Changed on 08/03/2017 at 08:22:36 AM by jwangenheim
- Cc LawannaURR removed
comment:10 Changed on 08/03/2017 at 12:53:12 PM by jwangenheim
- Description modified (diff)
comment:11 Changed on 08/04/2017 at 02:39:26 PM by jwangenheim
- Review URL(s) modified (diff)
- Status changed from reopened to reviewing
comment:12 Changed on 08/15/2017 at 11:39:49 AM by abpbot
A commit referencing this issue has landed:
Issue 5237 - Correct filter lists not applied on other language installation
comment:13 Changed on 08/15/2017 at 11:42:47 AM by jwangenheim
- Resolution set to fixed
- Status changed from reviewing to closed
comment:14 Changed on 09/17/2017 at 05:01:26 PM by rscott
- Verified working set
I started to work on that issue and the default subscription is selected according to the device language now. But that leads us to another problem. Per default no filter list updates were made on mobile connection, so if a user installs the app on mobile connection and i.e. the german filter list is selected as the default subscription it will not be updated (and stay empty) until he has a WIFI connection.
I would like to suggest two different approaches to solve this problem: