Opened on 05/12/2017 at 05:05:10 PM
Closed on 06/02/2017 at 10:04:15 AM
Last modified on 06/29/2017 at 04:45:03 PM
#5243 closed defect (fixed)
[ABP for Samsung Internet] - Clipped text across languages
| Reported by: | Shikitita | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.1 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | jwangenheim, diegocarloslima, mario, lisabielik, vickyyu | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by Shikitita)
Environment
Platform: Samsung S6
OS: Android 6.0.1
How to reproduce
- Install Adblock Plus for Samsung Internet and enable the content blocking functionality in Samsung Internet
- Change the device's language into Turkish
- Access ABP for Samsung Internet and tap on "Daha fazla engelleme seçeneği"
Observed behaviour
Three of the four different options have their text clipped at the end, as can be seen in the attached screenshot. The text "devre dışı bırak", which can't be read completely, means "disable" in Turkish and therefore should be properly displayed.
Note that this happens in other screens and in most languages except for Korean.
Expected behaviour
The text should be wrapped in order to display it fully to the user and help avoid misunderstandings.
Even though aesthetically it won't be too nice having the text in two lines, it is better than reducing the font's size (which should be done to all languages for that matter).
Attachments (6)
Change History (23)
Changed on 05/12/2017 at 05:05:26 PM by Shikitita
Changed on 05/16/2017 at 01:09:19 PM by jwangenheim
Changed on 05/16/2017 at 01:09:26 PM by jwangenheim
comment:2 Changed on 05/16/2017 at 01:11:15 PM by jwangenheim
comment:3 follow-up: ↓ 4 Changed on 05/16/2017 at 01:27:37 PM by Shikitita
Strings that would need to be displayed also in two lines:
- Add a website to the whitelist (affects different languages)
- Configure your filter lists (affects Greek)
Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below
Changed on 05/16/2017 at 01:28:34 PM by Shikitita
"Enable Adblock Plus in Samsung Internet 4.0 or above" clipped in French
Changed on 05/16/2017 at 01:58:52 PM by jwangenheim
Changed on 05/16/2017 at 01:58:58 PM by jwangenheim
comment:4 in reply to: ↑ 3 ; follow-up: ↓ 5 Changed on 05/16/2017 at 02:00:31 PM by jwangenheim
Replying to Shikitita:
Strings that would need to be displayed also in two lines:
- Add a website to the whitelist (affects different languages)
- Configure your filter lists (affects Greek)
Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below
I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.
comment:5 in reply to: ↑ 4 ; follow-up: ↓ 6 Changed on 05/16/2017 at 02:11:47 PM by Shikitita
Replying to jwangenheim:
Replying to Shikitita:
Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below
I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.
Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.
comment:6 in reply to: ↑ 5 ; follow-up: ↓ 10 Changed on 05/16/2017 at 02:16:37 PM by jwangenheim
Replying to Shikitita:
Replying to jwangenheim:
Replying to Shikitita:
Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below
I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.
Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.
Sorry, missed that. Then it might make sense to just use "Enable Adblock Plus in Samsung Internet"?
comment:7 Changed on 05/16/2017 at 02:17:31 PM by Shikitita
- Cc lisabielik added
comment:8 Changed on 05/16/2017 at 02:26:12 PM by jwangenheim
- Cc lisabielik removed
- Owner set to jwangenheim
- Ready set
comment:9 Changed on 05/16/2017 at 02:27:00 PM by jwangenheim
- Cc lisabielik added
comment:10 in reply to: ↑ 6 ; follow-up: ↓ 11 Changed on 05/16/2017 at 02:30:13 PM by Shikitita
- Cc vickyyu added
Replying to jwangenheim:
Replying to Shikitita:
Replying to jwangenheim:
Replying to Shikitita:
Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below
I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.
Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.
Sorry, missed that. Then it might make sense to just use "Enable Adblock Plus in Samsung Internet"?
Funny enough, that's how the string used to be before. However, not sure if we added the "4.0 or above" in order to make sure users knew that it'd only work in those versions of Samsung Internet. :-/
@lisa, vicky: Any thoughts on the above?
comment:11 in reply to: ↑ 10 Changed on 05/16/2017 at 02:32:03 PM by jwangenheim
Replying to Shikitita:
Replying to jwangenheim:
Replying to Shikitita:
Replying to jwangenheim:
Replying to Shikitita:
Also "Enable Adblock Plus in Samsung Internet 4.0 or above" is displayed clipped for quite a few of the languages. However, it's already displayed in two lines and maybe having it in three wouldn't look so nice. :-/ You can see this in the screenshot below
I've fixed the first two texts too. For the dialog title I would suggest to display it in three lines, as this would only affect french users. In my opinion this is better than having a smaller text size for all languages.
Unfortunately, like I mentioned above, this one is displayed clipped for quite a few languages: French, Greek, Turkish, German, Polish, Russian.
Sorry, missed that. Then it might make sense to just use "Enable Adblock Plus in Samsung Internet"?
Funny enough, that's how the string used to be before. However, not sure if we added the "4.0 or above" in order to make sure users knew that it'd only work in those versions of Samsung Internet. :-/
@lisa, vicky: Any thoughts on the above?
But if I understand the workflow correctly, this dialog is only displayed to users with at least Samsung Browser 4.0
comment:12 Changed on 05/17/2017 at 07:21:50 AM by jwangenheim
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:13 Changed on 05/18/2017 at 12:59:43 PM by jwangenheim
- Review URL(s) modified (diff)
comment:14 Changed on 05/23/2017 at 03:23:45 PM by diegocarloslima
- Priority changed from Unknown to P3
comment:15 Changed on 06/02/2017 at 10:02:56 AM by abpbot
A commit referencing this issue has landed:
Issue 5243 - Clipped text across languages
comment:16 Changed on 06/02/2017 at 10:04:15 AM by jwangenheim
- Milestone set to Adblock-Plus-for-Samsung-Browser-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:17 Changed on 06/29/2017 at 04:45:03 PM by Shikitita
- Verified working set
Text for items in "More blocking options" and "Acceptable Ads" (on startpage) can now be displayed in multiple lines. Please let me know what else should be displayed in two lines.