[abp2blocklist] Use wildcard to match any subdomains

[mjethani]

Background

Domain restrictions in Adblock Plus filters, specified with the domain option, normally apply to subdomains as well. When abp2blocklist converts these filters into content blocker rules, it translates the domain value into only two variants of the domain, one with and one without the www subdomain.

For example, this filter:

    /ads$domain=example.com

It gets converted into this rule:

{
  "trigger": {
    "url-filter": "^https?://.*/ads",
    "resource-type": [
      "image",
      "style-sheet",
      "script",
      "font",
      "media",
      "raw",
      "document"
    ],
    "if-domain": [
      "example.com",
      "www.example.com"
    ]
  },
  "action": {
    "type": "block"
  }
}

Since content blocker rules already support a wildcard syntax for matching any subdomains, abp2blocklist should use the wildcard syntax to cover any subdomains.

What to change

Remove the addDomainPrefix function and the tldjs dependency that came with it. Instead, simply add a * character in front of the name. e.g. $domain=example.com should get converted to "if-domain": ["*example.com"]

[abpbot]

A commit referencing this issue has landed:
​Issue 5248 - Use wildcard to match any subdomains