Opened on 05/18/2017 at 03:53:22 PM
Closed on 06/27/2017 at 01:11:21 PM
Last modified on 06/29/2017 at 02:48:55 PM
#5260 closed change (fixed)
[ABP for Samsung Internet] - Implement underline formatting to Korean
| Reported by: | Shikitita | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.1 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | jwangenheim, diegocarloslima, mario | Blocked By: | |
| Blocking: | Platform: | Samsung Browser | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by Shikitita)
Background
Different strings in the app have bold formatting in order to make that specific section stand out. Unfortunately, this isn't so noticeable for Korean.
What to change
Underline formatting should be added, in addition to the bold formatting, in order to give more emphasis to those specific sections.
Attachments (1)
Change History (9)
Changed on 05/22/2017 at 11:17:34 AM by Shikitita
comment:1 Changed on 05/23/2017 at 03:23:05 PM by diegocarloslima
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 06/14/2017 at 09:29:28 AM by jwangenheim
- Owner set to jwangenheim
comment:3 Changed on 06/14/2017 at 10:18:24 AM by Shikitita
- Description modified (diff)
- Summary changed from [ABP for Samsung Internet] - Implement backward slashes in Korean strings to [ABP for Samsung Internet] - Implement underline formatting to Korean
comment:4 Changed on 06/14/2017 at 10:34:39 AM by jwangenheim
- Milestone set to Adblock-Plus-for-Samsung-Browser-next
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 06/14/2017 at 10:40:44 AM by Shikitita
As it seems it cannot be removed, attachment KorStrings.zip should therefore be ignored as it was uploaded when the issue reflected a different fix than the one decided.
Last edited on 06/14/2017 at 10:41:30 AM
by Shikitita
comment:6 Changed on 06/27/2017 at 09:44:55 AM by abpbot
A commit referencing this issue has landed:
Issue 5260 - Implement underline formatting to Korean
comment:7 Changed on 06/27/2017 at 01:11:21 PM by jwangenheim
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 06/29/2017 at 02:48:55 PM by Shikitita
- Verified working set
Note: See
TracTickets for help on using
tickets.
Updated .xml file for Korean with the backward slashes added.