Opened on 05/20/2014 at 04:32:28 PM
Closed on 05/22/2014 at 08:47:59 AM
Last modified on 05/22/2014 at 01:31:03 PM
#527 closed change (fixed)
[stats] Only count requests from Adblock Plus extensions
| Reported by: | fhd | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Infrastructure | Keywords: | 2014q3 |
| Cc: | trev, jobp@adblockplus.org | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by fhd)
Background
Currently, we're counting all requests to notifications.json and exceptionrules.txt in the log processor. Since there are a few forks that also make these requests, we should only count requests from extensions that call themselves ABP.
What to change
Only count requests that have addonName set to one of those we use. Checking that it starts with adblockplus is probably sufficient, but that needs to be checked.
Attachments (0)
Change History (10)
comment:1 Changed on 05/21/2014 at 04:03:02 AM by fhd
- Cc trev added
comment:2 Changed on 05/21/2014 at 07:22:53 AM by trev
comment:4 Changed on 05/21/2014 at 07:37:26 AM by fhd
Changed the description a bit to avoid confusion. Feel free to elaborate in the "What to change" part.
comment:5 Changed on 05/21/2014 at 08:46:59 AM by fhd
- Priority changed from P2 to P1
Setting to P1 - since this is a change in the log processor and not the user counter as I expected, we should fix it ASAP to get proper data again.
comment:6 Changed on 05/21/2014 at 09:00:22 AM by jobp
- Cc jobp@adblockplus.org added
comment:7 Changed on 05/22/2014 at 07:21:48 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 05/22/2014 at 07:21:56 AM by sebastian
- Owner set to sebastian
comment:9 Changed on 05/22/2014 at 08:47:59 AM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 05/22/2014 at 01:31:03 PM by philll
- Keywords 2014q3 added
This isn't something that can be fixed in the user counter - we have to ignore other extensions in the log processor for the previousDownload field.