Opened on 05/24/2017 at 09:13:07 AM
Closed on 06/08/2017 at 11:39:37 AM
#5274 closed change (fixed)
Grant push access for Manish and Jon
| Reported by: | sebastian | Assignee: | ferris |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Office-IT | Keywords: | |
| Cc: | ferris, mjethani, jsonesen | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29451558/ (done) |
||
Description (last modified by sebastian)
Background
As per our committer guidelines the module owner can decide to grant write access for regular contributors to the respective repositories. Hereby I, the module owner of Platform and Build-and-Release-Tools, approve write access for the developers/repositories below.
What to change
- Grant write access for Manish Jethani to adblockpluschrome and abp2blocklist.
- Grant write access for Jon Sonesen to adblockpluschrome and buildtools.
Attachments (1)
Change History (14)
comment:1 Changed on 05/24/2017 at 09:15:09 AM by sebastian
comment:4 Changed on 05/24/2017 at 10:45:42 AM by matze
- Priority changed from Unknown to P2
- Ready set
comment:5 Changed on 05/24/2017 at 10:45:54 AM by matze
- Component changed from Infrastructure to Office-IT
comment:6 Changed on 05/30/2017 at 08:09:31 AM by jsonesen
I have my key on the server as I currently have push access for sitescripts and cms
comment:7 Changed on 05/30/2017 at 08:13:14 AM by ferris
Apologies, I didn't get any email notification from Trac when Manish attached his key. I have your key already, Jon. I'll commit the change shortly.
comment:8 Changed on 05/30/2017 at 08:24:55 AM by jsonesen
No problem, thanks Ferris!
comment:9 Changed on 05/30/2017 at 12:33:46 PM by ferris
- Review URL(s) modified (diff)
Jon is in. Will add Manish in a separate commit.
comment:10 Changed on 05/30/2017 at 01:23:58 PM by ferris
- Owner set to ferris
Changed on 06/07/2017 at 03:28:36 AM by mjethani
Manish's SSH key
comment:11 Changed on 06/07/2017 at 03:31:06 AM by mjethani
I've updated my key to 4096-bit RSA now.
comment:12 Changed on 06/08/2017 at 09:37:11 AM by ferris
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:13 Changed on 06/08/2017 at 11:39:37 AM by ferris
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from reviewing to closed
@mjethani, @jsonesen: If your key isn't on the server yet, if you don't have push access to any other repositories yet, please attach your public key to this issue.