Opened on 05/26/2017 at 07:54:28 AM
Closed on 06/19/2017 at 11:10:40 AM
Last modified on 12/12/2017 at 09:38:25 AM
#5278 closed defect (fixed)
'Last download' date for each filter list installed shows 1/1/70
| Reported by: | tibitts | Assignee: | trev |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Linux OpenSUSE 13.2 32-bit, FF 53.0.3, ABP 2.9, filter lists - see attached screenshot
How to reproduce
- Open ABP Filter Preferences
Observed behaviour
The 'Last download' date for each filter list installed shows 1/1/70 - see attached screenshot.
Expected behaviour
Show the correct 'Last download' date.
What to change
Change Utils.formatTime() method to use the standard Intl.DateTimeFormatter object.
Attachments (1)
Change History (9)
Changed on 05/26/2017 at 07:55:26 AM by tibitts
comment:1 Changed on 05/30/2017 at 09:56:03 AM by trev
- Component changed from Unknown to Adblock-Plus-for-Firefox
This isn't an issue I can see on Ubuntu, I will try running OpenSUSE. I assume that this doesn't change after updating the filter list either? Are you using the distribution supplied Firefox package? Is it a new issue or was it always like that?
comment:2 Changed on 05/30/2017 at 11:37:47 AM by trev
I can reproduce this using official Firefox 53 32-bit build on OpenSuSE 13.2 (distribution-supplied builds stopped at Firefox 50).
comment:3 Changed on 05/30/2017 at 12:27:46 PM by trev
- Description modified (diff)
- Priority changed from Unknown to P4
- Ready set
This appears to be a general issue with the 32-bit Firefox build - it is reproducible on both OpenSuSE and Ubuntu as long as you install the 32-bit build. It seems that nsIScriptableDateFormat implementation is broken, it will misrepresent dates despite being given correct parameters. However, seeing that nsIScriptableDateFormat is deprecated, I don't think that we can expect Mozilla to fix this. Intl.DateTimeFormat with work correctly in both 64-bit and 32-bit builds.
comment:4 Changed on 06/08/2017 at 07:59:27 AM by trev
- Owner set to trev
comment:5 Changed on 06/08/2017 at 08:13:27 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 06/19/2017 at 11:09:56 AM by abpbot
A commit referencing this issue has landed:
Issue 5278 - Improved date formatting approach, in particular fixing broken formatting in 32-bit Linux builds
comment:7 Changed on 06/19/2017 at 11:10:40 AM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 12/12/2017 at 09:38:25 AM by trev
- Milestone Adblock-Plus-for-Firefox-next deleted
Milestone Adblock-Plus-for-Firefox-next deleted
screenshot