Opened on 06/01/2017 at 09:06:21 AM
Closed on 06/04/2017 at 04:11:11 PM
Last modified on 06/05/2017 at 02:40:09 AM
#5285 closed defect (fixed)
Adblock Plus cannot save filters in clean Thunderbird or SeaMonkey profile
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.9.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Adblock Plus 2.9.0.4250-beta on Thunderbird or SeaMonkey, clean profile that didn't have Adblock Plus installed before.
How to reproduce
- Change Adblock Plus filters.
- Press Ctrl+Shift+J to open Browser Console.
- Disable and re-enable Adblock Plus.
Observed behaviour
I see an error message in Browser Console:
Unix error 2 during operation open on file /.../adblockplus/patterns.ini.tmp (No such file or directory)
No adblockplus/patterns.ini file is being created in the profile and data is lost after restarting the extension.
Expected behaviour
The data should be saved correctly, without any errors.
What to change
Make sure that adblockplus directory is created before attempting to write patterns.ini.
Attachments (0)
Change History (8)
comment:2 Changed on 06/01/2017 at 09:24:12 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/01/2017 at 12:04:39 PM by abpbot
comment:4 Changed on 06/01/2017 at 12:05:26 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 06/01/2017 at 01:23:05 PM by shellye5
sorry new to all this so commenting here as this seems similar
does it fix this in Firefox too? will it be in next 2.9 beta+stable?
I am having this exact problem in Firefox 52 & 55 + ABP 2.9 on fresh setup
When restoring Filters/updating them, the updated filters are lost after restart,
patters file is not saved with updated filters.
The filters show the last time they were updated/backed up in this case from 2.8 before updating to 2.9
In Adblock Plus 2.9.0.4251-beta too
The error:
Error: An unexpected error occurred filterStorage.js:607
saveToDisk/< jar:file:///userinfo/%7Bd10d0bf8-f5b5-c8b4-a8b2-2b9879e08c5d%7D.xpi!/lib/filterStorage.js:607:7
Cu.reportError(error);
On AMO many people are complaining about this issue.
comment:6 Changed on 06/01/2017 at 01:44:01 PM by shellye5
- Resolution fixed deleted
- Status changed from closed to reopened
comment:7 Changed on 06/04/2017 at 04:11:11 PM by trev
- Resolution set to fixed
- Status changed from reopened to closed
The issue here has been resolved. What you are seeing is an unrelated issue, likely #5281 though it's hard to tell without being able to reproduce.
comment:8 Changed on 06/05/2017 at 02:40:09 AM by udo
I could download older binaries of previous FF.
Where can I find previous adblocker to test?
A commit referencing this issue has landed:
Issue 5285 - Fix saving filters on clean Thunderbird or SeaMonkey profiles