Opened on 06/06/2017 at 10:15:47 AM
Closed on 06/06/2017 at 01:15:29 PM
Last modified on 06/07/2017 at 12:27:38 PM
#5298 closed change (fixed)
Disable filter hit counts by default
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.9.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by trev)
Background
https://bugzilla.mozilla.org/show_bug.cgi?id=1362779 indicates that filter hit counts might be responsible for performance issues on some websites. For reference, 250 filter hits will currently cause filters data to be updated on disk. While this is supposed to be a relatively fast operation, for some users apparently it isn't.
What to change
Disable filter hit counting by default which should be beneficial for most users. Only count filter hits for users who enable it manually (that should be filter list authors for most part).
Hints for testers
In addition to performance implications (see #5284, definitely visible on focus.de, other websites are not as clear), it should be tested that filter authors can still re-enable filter hit counting in options and it will work.
Attachments (0)
Change History (7)
comment:1 Changed on 06/06/2017 at 12:56:52 PM by trev
- Ready set
comment:2 Changed on 06/06/2017 at 12:57:05 PM by trev
- Owner set to trev
comment:3 Changed on 06/06/2017 at 01:10:30 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 06/06/2017 at 01:14:57 PM by abpbot
A commit referencing this issue has landed:
Issue 5298 - Disable filter hit counts by default
comment:5 Changed on 06/06/2017 at 01:15:29 PM by trev
- Milestone set to Adblock-Plus-2.9.1-for-Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 06/07/2017 at 12:27:38 PM by rscott
LGTM. In FF 53.0.3/64bit on Ubuntu Xenial, with the out-of-the-box multiprocess setup, these are the performance profiles I get from loading focus.de and scrolling to the bottom of the page:
- ABP 4251: https://perfht.ml/2sfoGKY
- ABP 4252: https://perfht.ml/2sfMGhf
There's a notable user-visible performance improvement as well.
This has been confirmed as the source of at least some recent bug reports. The issue has been made worse by Adblock Plus 2.9 using browser.storage API to save data which is currently quite inefficient (see https://bugzilla.mozilla.org/show_bug.cgi?id=1277612 and https://bugzilla.mozilla.org/show_bug.cgi?id=1320186).