Opened on 06/13/2017 at 02:37:04 PM

Closed on 06/19/2017 at 02:02:59 PM

#5314 closed change (fixed)

Don't limit hide emulation filters to -abp pseudo class selectors

Reported by: hfiguiere Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Core Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29464708

Description (last modified by hfiguiere)

Background

Following issue #5287, we should not limit hide emulation filters to -abp pseudo-class selector

What to change

-in lib/filterClasses.js, around line 973, remove the check.
-make sure that unless it is -abp-properties, we actually hide the elements directly.
-ensure the tests pass.

Attachments (0)

Change History (6)

comment:1 Changed on 06/13/2017 at 02:40:08 PM by hfiguiere

  • Description modified (diff)

comment:2 Changed on 06/14/2017 at 02:15:36 AM by hfiguiere

  • Description modified (diff)
  • Summary changed from Don't limit hiding emulation filters to -abp pseudo class selectors to Don't limit hide emulation filters to -abp pseudo class selectors

comment:3 Changed on 06/14/2017 at 03:09:00 AM by hfiguiere

  • Owner set to hfiguiere

comment:4 Changed on 06/14/2017 at 03:19:39 AM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:5 Changed on 06/19/2017 at 02:02:28 PM by abpbot

A commit referencing this issue has landed:
​Issue 5314 - Allow hide emulation filters to be with a plain selector

comment:6 Changed on 06/19/2017 at 02:02:59 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.