Opened on 07/03/2017 at 09:16:55 AM
Closed on 08/08/2017 at 12:04:02 PM
Last modified on 08/10/2017 at 05:11:41 AM
#5360 closed defect (fixed)
Whitelist subscription shown as '-user-35236'
| Reported by: | scheer | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P4 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | diegocarloslima, mario | Blocked By: | |
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by diegocarloslima)
When the user unselects the 'block ads on this website' from the options menu, a whitelist subscription is created for the site and placed into 'More blocking options' with a title similar to '-user-35236'. The whitelist subscription should have a more meaningful name as opposed to a generic user/number reference.
Environment
adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
How to reproduce
- Visit any web page
- Select the settings menu
- De-select 'Block ads on this site'
- Go to settings page
- Go to Ad blocking
- Go to 'More blocking options'
Observed behaviour
A whitelist subscription named '-user-35236' or similar is shown.
Expected behaviour
The whitelist subscription should have a comprehensive name (e.g. Whitelisted websites).
Attachments (0)
Change History (9)
comment:1 Changed on 08/04/2017 at 01:57:23 PM by diegocarloslima
comment:3 Changed on 08/04/2017 at 07:07:28 PM by diegocarloslima
- Summary changed from User added whitelist shown as '-user-35236' and not the URL name to Whitelist subscription shown as '-user-35236'
comment:4 Changed on 08/04/2017 at 07:09:32 PM by diegocarloslima
- Owner set to diegocarloslima
- Priority changed from Unknown to P4
- Ready set
comment:5 Changed on 08/04/2017 at 07:10:54 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 08/08/2017 at 12:01:38 PM by abpbot
A commit referencing this issue has landed:
Issue 5360 - Whitelist subscription shown as '-user-35236'
comment:7 Changed on 08/08/2017 at 12:04:02 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-1.2.0
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 08/09/2017 at 06:55:38 PM by abpbot
A commit referencing this issue has landed:
Issue 5360 - Whitelist subscription shown as '-user-35236'
This seems to be due to some internal change in ABP after updating it to 2.7.3. It used to return 'Exception Rules' as a title for the whitelisting subscription. Now, it returns null for the title and with that, the url is being used instead, which is ~user~ and some random number.