Opened on 07/11/2017 at 10:18:13 AM
Closed on 08/08/2017 at 11:48:22 AM
#5404 closed defect (fixed)
:-abp-properties() nested within :-abp-has() doesn't work if the relevant selector refers to outside nodes
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #5436 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Adblock Plus for Chrome 1.13.2.1786 development build
How to reproduce
- Add adblockplus.org#?##summary:-abp-has(:-abp-properties(color: rgb(51, 51, 51))) to your custom filters.
- Go to https://adblockplus.org/
Observed behaviour
The text above the download button (in particular, the feature list) is visible.
Expected behaviour
The text above the download button should be hidden.
Background
:-abp-properties() pseudo will produce some selectors, in this particular case #summary ul. The current implementation of :-abp-has() will currently combine these selectors with the selector for the candidate element, so that we are effectively testing #summary #summary ul - this selector doesn't have any matches because the #summary element isn't located within itself.
What to change
Don't combine selectors produced by :-abp-properties(), rather limit queryElement() call to the necessary element so that no elements outside of it are returned.
Attachments (0)
Change History (7)
comment:1 Changed on 07/11/2017 at 10:21:36 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 07/11/2017 at 11:04:37 AM by abpbot
comment:3 Changed on 07/11/2017 at 11:12:10 AM by trev
Leaving open because this needs to land on master as well, so far this went to a branch only.
comment:4 Changed on 07/11/2017 at 01:08:48 PM by Ross
Fixed.
ABP 1.13.2.1787
Chrome 51+ / Windows 7
Opera 38+ / Windows 7
comment:5 Changed on 08/04/2017 at 09:48:32 PM by hfiguiere
- Blocking 5436 added
comment:6 Changed on 08/08/2017 at 11:47:48 AM by abpbot
A commit referencing this issue has landed:
Issue 5404 - :-abp-properties() nested within :-abp-has() should work if the relevant selector refers to outside nodes
comment:7 Changed on 08/08/2017 at 11:48:22 AM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
Landed on master now, only context changed slightly here.
A commit referencing this issue has landed:
Issue 5404 - :-abp-properties() nested within :-abp-has() should work if the relevant selector refers to outside nodes