Opened on 07/12/2017 at 08:04:57 PM
Closed on 08/17/2017 at 02:48:47 PM
Last modified on 10/08/2019 at 05:53:58 PM
#5409 closed defect (fixed)
Build fails due to mp4parse
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.3.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Build fails in abb_fennec_53_0_2_merge with the following error message:
error[E0463]: can't find crate for `cheddar` --> /Users/dlima/Workspace/adblockbrowser/media/libstagefright/binding/mp4parse_capi/build.rs:1:1 | 1 | extern crate cheddar; | ^^^^^^^^^^^^^^^^^^^^^ can't find crate error: aborting due to previous error error: Could not compile `mp4parse_capi`.
This is due to a known Firefox bug and since the fix was only pushed in Firefox 54, we need to apply this fix to our 53 merge
Attachments (0)
Change History (19)
comment:1 Changed on 07/12/2017 at 09:30:20 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/07/2017 at 09:33:13 PM by abpbot
comment:3 Changed on 08/17/2017 at 02:48:47 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 09/28/2017 at 02:15:19 PM by traynard
If this item is testable, please provide some testing information/instructions
comment:5 Changed on 09/28/2017 at 07:42:11 PM by diegocarloslima
@traynard: This is a build time issue. I believe that the best way to test it is by building the ABB project and checking if it performs successfully. Since I was able to build the project in order to generate the release candidate .apk, I think that we might consider this as verified working.
comment:6 Changed on 10/02/2017 at 10:31:26 PM by traynard
- Verified working set
@diegocarloslima: Thanks! Marked it as verified working then.
comment:7 Changed on 11/05/2018 at 01:15:26 PM by johnson83
spam
comment:8 Changed on 02/14/2019 at 11:26:44 PM by zinbad
spam
comment:9 Changed on 05/10/2019 at 07:57:53 AM by Paradee
spam
comment:10 Changed on 05/22/2019 at 08:28:50 PM by vegus111
spam
comment:11 Changed on 05/24/2019 at 06:27:10 PM by piwpak
spam
comment:12 Changed on 06/01/2019 at 02:49:44 AM by uw777
spam
comment:13 Changed on 06/03/2019 at 05:04:48 PM by piwpak3
spam
comment:14 Changed on 06/07/2019 at 03:35:03 PM by homemade99
spam
comment:15 Changed on 07/19/2019 at 09:04:51 AM by niki555
spam
comment:16 Changed on 07/19/2019 at 09:05:30 AM by niki555
spam
comment:17 Changed on 09/04/2019 at 09:28:44 AM by nps1337
spam
comment:18 Changed on 09/06/2019 at 01:49:00 PM by nps1337
spam
comment:19 Changed on 09/17/2019 at 07:19:51 AM by impulsepp
spam
A commit referencing this issue has landed:
Issue 5409 - Build fails due to mp4parse