Opened on 07/22/2017 at 04:34:31 PM
Closed on 01/30/2018 at 07:03:44 PM
Last modified on 01/30/2018 at 07:04:03 PM
#5439 closed change (rejected)
Add preferred site name microdata to eyeo websites
| Reported by: | juliandoucette | Assignee: | |
|---|---|---|---|
| Priority: | P5 | Milestone: | |
| Module: | Websites | Keywords: | goodfirstbug |
| Cc: | ire, wspee, saroyanm, lisabielik, jeen | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
See https://developers.google.com/search/docs/data-types/sitename
What to change
Set the required properties in the example below.
<head itemscope itemtype="http://schema.org/WebSite"> <title itemprop='name'>Your WebSite Name</title> <link rel="canonical" href="https://example.com/" itemprop="url">
Attachments (0)
Change History (9)
comment:1 Changed on 07/22/2017 at 04:36:28 PM by juliandoucette
- Summary changed from Set preferred site name on eyeo websites to Add preferred site name microdata to eyeo websites
comment:2 Changed on 07/22/2017 at 05:32:00 PM by juliandoucette
- Ready unset
comment:3 Changed on 07/24/2017 at 07:40:45 AM by ire
comment:4 follow-up: ↓ 5 Changed on 07/25/2017 at 12:53:43 PM by juliandoucette
Were you able to find any more information about this besides what is on that page? It's a bit unclear to me how to separate the page title from the site title. The example suggests that we just add the itemprop="name" attribute to the <title> element, but what if the title element contains the page title, not the site title?
Good question. I don't think it matters what elements we attach these itemprops to. Therefore, I would suggest that we attach them to our og:site_name (for example) instead.
Do you think it makes sense to add these to website defaults in some way? Considering that they are mainly attributes, not elements that can be included.
Yes. If we take my suggestion above then we could add it to includes/meta/social.tmpl.
comment:5 in reply to: ↑ 4 Changed on 07/26/2017 at 07:57:18 AM by ire
Good question. I don't think it matters what elements we attach these itemprops to. Therefore, I would suggest that we attach them to our og:site_name (for example) instead.
Okay. If this is the case then your suggestion works.
I have been trying to find actual examples of this being implemented on a site to make sure, but it doesn't seem like Google's own sites have added this property :/. I even did a Google search for "History of Google" like it showed in the example, and 1. The search results don't show a site name as in the example, and 2. The sites don't use the itemprop="name" attribute. I'm not sure what this means, or if it is relevant at all. Any thoughts?
comment:6 follow-up: ↓ 7 Changed on 07/26/2017 at 11:01:20 AM by juliandoucette
Any thoughts?
- I haven't been able to find any examples either
- I'm guessing Google supports fallbacks e.g. og:site_name
- I'm also guessing that Google provides a way to set this name manually
- This is a basic schema (Website)
- I think that anything that we can do to improve our search and share results is worth doing
comment:7 in reply to: ↑ 6 Changed on 07/26/2017 at 03:21:48 PM by ire
Replying to juliandoucette:
- I think that anything that we can do to improve our search and share results is worth doing
Agreed. I don't think there's any downside to including the attributes anyway so we may as well go ahead.
comment:8 Changed on 09/04/2017 at 10:55:16 AM by juliandoucette
- Priority changed from P3 to P5
comment:9 Changed on 01/30/2018 at 07:03:44 PM by juliandoucette
- Resolution set to rejected
- Status changed from new to closed
I'm rejecting this ticket because it's too broad and probably unnessisary. We can/will create a more specific ticket in gitlab as/if needed.
@juliandoucette Good one. A couple questions:
Were you able to find any more information about this besides what is on that page? It's a bit unclear to me how to separate the page title from the site title. The example suggests that we just add the itemprop="name" attribute to the <title> element, but what if the title element contains the page title, not the site title?
Do you think it makes sense to add these to website defaults in some way? Considering that they are mainly attributes, not elements that can be included.