Opened on 07/28/2017 at 03:47:41 PM
Closed on 09/22/2017 at 01:33:00 PM
#5458 closed change (fixed)
Add support to specify the locale of a user in the notification repository
Reported by: | wspee | Assignee: | wspee |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kvas | Blocked By: | #5460 |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | no | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description (last modified by trev)
Background
For our upcoming cross promotion campaign we want to be able to show notifications to users that use a specific locale.
What to change
Add support to specify the locale of a user by adding a space separated list of locales.
Notification repository format:
inactive = no severity = normal title.en-US = Test message.en-US = Test target = extension=adblockpluschrome locale=en-US locale=de
Resulting notification.json:
{ "notifications": [ { "targets": [{ "extension": "adblockpluschrome", "locales": ["en-US", "de"] }], "id": "1", "message": { "en-US": "Test" }, "severity": "normal", "title": { "en-US": "Test" } } ], "version": "201707281538" }
Attachments (0)
Change History (7)
comment:1 Changed on 07/28/2017 at 03:48:47 PM by wspee
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 07/31/2017 at 08:34:25 AM by wspee
- Owner set to wspee
comment:4 Changed on 07/31/2017 at 03:30:44 PM by wspee
- Blocked By 5460 added
comment:6 Changed on 09/22/2017 at 10:38:27 AM by kvas
A commit referencing this issue has landed:
Issue 5457, 5458 - Added support for locales and blocked total to notification parser...
I guess the commit message should have started with Issue 5457, Issue 5458 -. Perhaps we should document this.
comment:7 Changed on 09/22/2017 at 01:33:00 PM by wspee
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
I've updated the suggested format as mentioned in #5460 review.