Opened on 05/23/2014 at 06:24:19 AM
Closed on 08/26/2014 at 12:55:05 PM
Last modified on 08/26/2014 at 04:35:27 PM
#547 closed change (fixed)
Refactor proxy registration
| Reported by: | fhd | Assignee: | rjeschke |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-for-Android-1.3 |
| Module: | Adblock-Plus-for-Android | Keywords: | |
| Cc: | rjeschke, trev | Blocked By: | |
| Blocking: | #135 | Platform: | Android |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
The proxy registration logic is currently very hard to follow, and harder to add to.
What to change
Make the code more flexible and more maintainable. We should discuss the approach here.
Attachments (0)
Change History (9)
comment:1 Changed on 07/24/2014 at 07:36:41 AM by fhd
- Blocking 135 added
comment:2 Changed on 07/24/2014 at 07:37:09 AM by fhd
- Owner set to rjeschke
- Platform set to Android
- Priority changed from P3 to P2
comment:3 Changed on 08/13/2014 at 05:20:53 PM by rjeschke
- Blocking 1214 added
comment:4 Changed on 08/13/2014 at 05:54:05 PM by rjeschke
- Blocking 1214 removed
- Review URL(s) modified (diff)
comment:5 Changed on 08/13/2014 at 05:54:24 PM by rjeschke
comment:6 Changed on 08/25/2014 at 12:08:14 PM by trev
- Cc trev added
This was pushed: https://hg.adblockplus.org/adblockplusandroid/rev/376a06af35f9
@rjeschke: is more coming or is this issue fixed?
comment:7 Changed on 08/26/2014 at 12:54:38 PM by rjeschke
@trev this here is fixed, closing it now.
comment:8 Changed on 08/26/2014 at 12:55:05 PM by rjeschke
- Resolution set to fixed
- Status changed from new to closed
comment:9 Changed on 08/26/2014 at 04:35:27 PM by trev
- Milestone set to Adblock-Plus-for-Android-1.3
Note: See
TracTickets for help on using
tickets.
First part of review in progress.