Opened on 08/09/2017 at 09:11:57 AM

Closed on 08/30/2017 at 10:25:43 AM

#5480 closed change (fixed)

Add "watch" task to website-defaults gulpfile

Reported by: ire Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords: goodfirstbug
Cc: juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29529760

Description

Background

The website-defaults gulpfile has one task, scss, which compiles SCSS to CSS. When the gulp command is run, it runs this task once and ends.

What to change

  1. Add a watch task to watch all .scss files and automatically run the scss task: 
gulp.task("watch", function ()
{
  gulp.watch("scss/**/*.scss", ["scss"]);
});
  1. Add the watch task to the default gulp task: 
gulp.task("default", ["scss", "watch"]);

Attachments (0)

Change History (4)

comment:1 Changed on 08/28/2017 at 03:05:20 PM by ire

  • Owner set to ire
  • Ready set

comment:2 Changed on 08/28/2017 at 03:05:38 PM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/30/2017 at 10:25:16 AM by abpbot

A commit referencing this issue has landed:
​Issue 5480 - Add "watch" task to website-defaults gulpfile

comment:4 Changed on 08/30/2017 at 10:25:43 AM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.