Opened on 08/11/2017 at 08:59:53 AM
Last modified on 09/24/2019 at 02:29:39 PM
#5499 reviewing change
Add tests for websocket and webrtc filter options
| Reported by: | sergz | Assignee: | Ross |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | fhd, ubernitt, greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/testpages.adblockplus.org/merge_requests/11 |
||
Description
Background
#5475 introduces these new filter options which are now supported by adblockpluscore, therefore maybe some existing tests should be adapted as well as new tests for these types should be created.
What to do
Check existing tests and add new tests.
Attachments (0)
Change History (10)
comment:1 Changed on 08/11/2017 at 09:00:55 AM by sergz
comment:2 Changed on 08/11/2017 at 02:48:03 PM by sergz
- Blocking 5475 removed
comment:3 Changed on 08/11/2017 at 02:48:08 PM by sergz
- Blocked By 5475 added
comment:4 Changed on 03/12/2019 at 09:20:56 AM by ubernitt
Links to DP-95 in the DP Team Jira board
comment:5 follow-up: ↓ 6 Changed on 03/13/2019 at 10:26:00 AM by Ross
Does this ticket refer to adding to the unit tests in adblockpluscore/adblockpluschrome or to the test pages? I'm assuming the first by this tickets age.
comment:6 in reply to: ↑ 5 Changed on 03/22/2019 at 03:46:37 PM by ubernitt
Replying to Ross:
Does this ticket refer to adding to the unit tests in adblockpluscore/adblockpluschrome or to the test pages? I'm assuming the first by this tickets age.
Sorry for not seeing your question :(! No! At least, what we as the DP team care for, It's all about the test pages.
comment:7 Changed on 03/22/2019 at 03:48:10 PM by ubernitt
- Cc ubernitt added
comment:8 Changed on 04/03/2019 at 03:16:57 PM by Ross
- Blocked By 5475 removed
- Component changed from Libadblockplus to Websites
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 04/04/2019 at 10:02:24 AM by abpbot
A commit referencing this issue has landed:
Issue 5499 - Fix the WebRTC test page
comment:10 Changed on 09/24/2019 at 02:29:39 PM by greiner
- Cc greiner added
- Owner set to Ross
See examples in git commit https://github.com/adblockplus/adblockpluscore/commit/bef643ecc69fa099e7c31a631ce4cf81decb20e9