Opened on 08/11/2017 at 10:13:51 AM

Last modified on 10/08/2019 at 05:54:28 PM

#5503 new change

Create libadblockplus-v8-project

Reported by: sergz Assignee:
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: rjeschke, hfiguiere, tlucas, asmirnov Blocked By:
Blocking: #6260 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sergz)

Background

In order to provide with V8 binaries for CI (#5133) and to simplify testing against another versions of V8 we need a set of scripts or whatever what builds a particular version of V8 for linux-x64-debug, macOS-x64-debug, windows-{32, 64}bit-{Release, Debug}, android-{arm, arm64, x86}-release and prepares required archives for further usage and uploading.

Right now these files are prepared by manual invocation of the compilation of libadblockplus for each case and following gathering of data. This process takes a lot of time and requires a lot of attention.

What to change

For the beginning create the repository with building scripts (https://github.com/abby-sergz/v8-project/tree/ci-master and https://github.com/abby-sergz/libadblockplus/blob/v8-packer/build-v8-pack.py can be helpful, however it should be adjusted in accordance with the latest changes in libadblockplus) and dependencies.

Additional notes

Consider automating it by having a configuration for some CI-services, however, currently it's impossible to use in particular travis-ci because it runs out of time (50 minutes limit) while compiling of V8, it takes a lot of time especially for android where V8 basically has to be built twice for the target and for a host, for the latter in order to get mksnapshot. Just in case, for the beginning a simple script building and preparing for a particular configuration or configurations would be sufficient.

---
Libadblockplus module is set for present to don't miss this issue and because libadblockplus is the closest project to it.

Attachments (0)

Change History (10)

comment:1 Changed on 09/29/2017 at 09:30:27 AM by sergz

  • Description modified (diff)

comment:2 Changed on 01/16/2018 at 12:37:14 PM by asmirnov

  • Blocking 6260 added

comment:3 follow-up: Changed on 03/27/2018 at 10:47:56 AM by sergz

  • Cc rjeschke hfiguiere tlucas asmirnov added
  • Priority changed from P4 to P2

According to https://www.chromium.org/developers/calendar we will have to deal with V8 without gyp (which was deprecated long ago) configuration before summer. It means that probably one will not be able to consume V8 and its few dependencies as we are doing it right now. So I have increased the priority of this issue in order to be prepared, in particular to not introduce unexpected delays, which can affect any integration of libadblockplus. (The latter is very crucial, please approach me for details).

I have added @tlucas here because it would be very helpful if we could borrow someone

  • who can help to create the proper building scripts which are consistent with our other scripts,
  • ensure that all dependencies are mirrored for the resilience (we do know from the experience that some repositories just disappeared, what would make it impossible to have a build of our products, even not previous versions of it, though such tasks appear sometimes too), and
  • who can spend some time for that because it's a very time consuming task.

comment:4 Changed on 03/28/2018 at 10:29:12 PM by hfiguiere

FWIW, I'm still working on issue #6226 to switch libadblockplus to meson (the patch in review currently works for compiling natively, I'm addressing the cross-compilation)

This should help.

comment:5 in reply to: ↑ 3 ; follow-up: Changed on 04/09/2018 at 03:42:23 PM by tlucas

Replying to sergz:

...
I have added @tlucas here because it would be very helpful if we could borrow someone

  • who can help to create the proper building scripts which are consistent with our other scripts,
  • ensure that all dependencies are mirrored for the resilience (we do know from the experience that some repositories just disappeared, what would make it impossible to have a build of our products, even not previous versions of it, though such tasks appear sometimes too), and
  • who can spend some time for that because it's a very time consuming task.

I would definitely love to help and participate, at least for the scripting part - but unfortunately i can not promise to be able to spend too much time (consecutively).

FWIW, did you by any chance create http://hub.eyeo.com/issues/9767 out of this general topic?

comment:6 in reply to: ↑ 5 Changed on 04/10/2018 at 09:46:45 AM by sergz

Replying to tlucas:

....
FWIW, did you by any chance create http://hub.eyeo.com/issues/9767 out of this general topic?

Yes, but this issue is mere one case, another one is http://hub.eyeo.com/issues/9562, and there is always something where one could improve the quality and productivity by collaborating with dev-ops.

comment:7 Changed on 06/19/2018 at 09:07:35 AM by asmirnov

  • Blocking 6750 added

comment:8 Changed on 06/22/2018 at 11:28:05 AM by sergz

  • Blocking 6750 removed

comment:9 Changed on 09/19/2018 at 08:50:39 AM by johnson83

spam

Last edited on 10/08/2019 at 05:54:28 PM by kzar

comment:10 Changed on 06/01/2019 at 03:37:25 AM by uw777

spam

Last edited on 10/08/2019 at 05:54:25 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
 
Note: See TracTickets for help on using tickets.