Opened on 08/11/2017 at 02:56:40 PM

Closed on 09/14/2017 at 03:55:06 PM

#5510 closed change (fixed)

Check that in compat.js XMLHttpRequest onload is what we want when error occurs

Reported by: sergz Assignee: hfiguiere
Priority: Unknown Milestone:
Module: Libadblockplus Keywords:
Cc: hfiguiere Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29544685

Description

Background

It seems that we should rather use this["on" + eventName].call(this, event);, namely, onerror, ​https://github.com/adblockplus/libadblockplus/blob/7446b2d2068b225aeb2645a7097eff6790d6f079/lib/compat.js#L405.

Attachments (0)

Change History (4)

comment:1 Changed on 09/14/2017 at 03:43:29 PM by hfiguiere

  • Owner set to hfiguiere

comment:2 Changed on 09/14/2017 at 03:45:57 PM by hfiguiere

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 09/14/2017 at 03:54:21 PM by abpbot

A commit referencing this issue has landed:
​Issue 5510 - Call onerror in case of error

comment:4 Changed on 09/14/2017 at 03:55:06 PM by hfiguiere

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from hfiguiere.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.