Opened on 08/18/2017 at 01:56:38 PM

Closed on 08/25/2017 at 03:59:14 PM

#5540 closed change (fixed)

Implement user notifications and "Whitelist added" notification for new options page

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: greiner, juliandoucette Blocked By:
Blocking: #5158 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29519650/

Description

Background

After several design iterations we finally have a final version of the new options page (See #5158)

What to change

Implement notification and show the notification for the added whitelist domain as specified in the ​​Options Page ​​Specification.

Attachments (0)

Change History (4)

comment:1 Changed on 08/18/2017 at 08:11:50 PM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 08/18/2017 at 10:09:09 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 08/25/2017 at 03:58:16 PM by abpbot

A commit referencing this issue has landed:
Issue 5540 - implement notification

comment:4 Changed on 08/25/2017 at 03:59:14 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.