Opened on 08/25/2017 at 09:46:10 AM
Closed on 09/26/2017 at 08:21:02 PM
#5574 closed change (fixed)
Update to current jQuery and jQuery UI versions
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-3.0-for-Firefox |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, greiner | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
Mozilla requires at least jQuery 2.0 for extensions, our jQuery 1.7.1 is considered unsafe. However, when updating jQuery, jQuery UI has to be updated as well, since our version (jQuery UI 1.8) is incompatible with jQuery 1.9 and newer versions.
What to change
Update to current jQuery and jQuery UI versions, make the necessary adjustments to our code.
Hints for testers
This change effects the (old) options page and the "Block element" dialog. Some visual minor changes are to be expected, as long as they don't impair the usability. Also make sure that all UI functionality is still working as before, and that no JavaScript errors are logged in the developer tools.
Attachments (0)
Change History (9)
comment:1 Changed on 08/25/2017 at 09:49:08 AM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 08/25/2017 at 10:58:25 AM by trev
- Component changed from Platform to User-Interface
comment:3 Changed on 08/25/2017 at 11:22:29 AM by greiner
- Cc greiner added
- Platform changed from Unknown / Cross platform to Firefox
- Priority changed from Unknown to P1
- Ready set
comment:4 Changed on 08/25/2017 at 11:37:39 AM by abpbot
comment:5 Changed on 08/25/2017 at 11:38:57 AM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 09/11/2017 at 01:18:43 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. UI still works as expected and no errors appear to occur.
ABP 1.13.13.1838
Chrome 49 / 60 / Windows 7
Opera 36 / 46 / Windows 7
comment:8 Changed on 09/26/2017 at 02:51:06 AM by sebastian
- Milestone changed from Adblock-Plus-1.13.4-for-Chrome-Opera to Adblock-Plus-for-Chrome-Opera-next
- Resolution fixed deleted
- Status changed from closed to reopened
This change has been backed out, for now, due to #5748.
comment:9 Changed on 09/26/2017 at 08:21:02 PM by sebastian
- Resolution set to fixed
- Status changed from reopened to closed
This change was only backed out in master prior to the Adblock plus 1.13.4 release. It was never backed out in next wich now became the new master. Therefore closing again.
A commit referencing this issue has landed:
Issue 5574 - Update to current jQuery and jQuery UI versions