Update adblockpluscore dependency 217eff0504a5

[hfiguiere]

Background

Update adblockpluscore dependency

What to change

Update adblockpluscore dependency to

hg	git
217eff0504a5	48eddbc

Make sure that elemHideEmulation is packaged as a module (see #5516).

Included changes

Ticket	Summary	Component
#5558	Make notifications not ignore unknown targets	Core
#5516	Bundle the browser tests and dependencies using webpack, adding module support	Core
#5460	Add support to show a notification based on the locale of the user	Core
#5459	Add support to show a notification based on the number of ads blocked	Core
#5438	Listen to DOM changes to eventually reapply filters.	Core
#5436	Relative selectors in :-abp-has() broken	Core
#5422	Property selector matching * selector doesn't work	Core
#5381	CSS property filters error in old Chrome versions	Core
#5339	Properly select element from pseudo-element	Core
#5079	Export ElemHideEmulation and splitSelector	Core

​adffd8564570	Noissue - Refactored notification target checking (checkTarget) to make it more easily expandable	Winsley von Spee
​d84358f9e0c0	Noissue - Added testcase to show that unknown notification targets are ignored	Winsley von Spee
​e775d9190f02	Noissue - Enable source map for the tests	Hubert Figuière
​3af11978db00	Noissue - Updated copyright year	Wladimir Palant
​8a9c308bb8fb	Noissue - Reorder chromium_process.js imports	Dave Barker
​b935a0402215	Noissue - Throw an error if the client code doesn't load	Hubert Figuière
​1a633dad14b4	Noissue - Remove unused reportError	Hubert Figuière

Hints for testers

• Issues #5459, #5460, #5558 implement changes to notification handling. Testing the notification mechanism is non-trivial unfortunately.
• Issues #5079, #5339, #5381, #5422, #5436, #5438, #5516 all affect element hiding emulation functionality, please refer to the descriptions in the respective issues.
• Issue #5000 isn't part of the list but has been resolved implicitly by #5438 and #5339 and should be retested.
• The commits without issue have no impact on the build or affect functionality already covered by one of the issues above.

[abpbot]

A commit referencing this issue has landed:
​Issue 5584 - Update adblockpluscore dependency to hg:217eff0504a5

[hfiguiere]

We should revert the patch for now. We are missing issue #5535

[hfiguiere]

Backed out: ​https://hg.adblockplus.org/adblockpluschrome/rev/da77bea78f0f

[kzar]

This isn't blocked by 5535, here's an example of how to do the dependency update before the webpack stuff landed.

diff --git a/dependencies b/dependencies
index b4b2343f..40467730 100644
--- a/dependencies
+++ b/dependencies
@@ -2,5 +2,5 @@ _root = hg:https://hg.adblockplus.org/ git:https://github.com/adblockplus/
 _self = buildtools/ensure_dependencies.py
 buildtools = buildtools hg:4276509ccff9 git:3eb4cc7
 adblockplus = adblockplus hg:c8ec667756d3 git:9a42447
-adblockpluscore = adblockpluscore hg:442aa536668a git:65f427d
+adblockpluscore = adblockpluscore hg:217eff0504a5 git:48eddbc
 adblockplusui = adblockplusui hg:9976daa84915 git:1ec5c0d
diff --git a/include.preload.js b/include.preload.js
index 6d318808..f0e93a94 100644
--- a/include.preload.js
+++ b/include.preload.js
@@ -15,7 +15,8 @@
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-/* globals ElemHideEmulation, splitSelector */
+let {splitSelector} = require("common");
+let {ElemHideEmulation} = require("content_elemHideEmulation");
 
 "use strict";
 
diff --git a/metadata.chrome b/metadata.chrome
index 4f9b64e2..6ed4feb1 100644
--- a/metadata.chrome
+++ b/metadata.chrome
@@ -115,7 +115,8 @@ lib/adblockplus.js[injectinfomodule] = true
 lib/adblockplus.js[autoload] = filterListener,synchronizer,requestBlocker,popupBlocker,subscriptionInit,filterComposer,stats,uninstall,csp,cssInjection
 include.preload.js = include.preload.js inject.preload.js
 include.postload.js = subscriptionLink.postload.js composer.postload.js
-elemHideEmulation.js = adblockpluscore/lib/common.js adblockpluscore/chrome/content/elemHideEmulation.js
+elemHideEmulation.js = adblockpluscore/lib/common.js adblockpluscore/lib/content/elemHideEmulation.js
+elemHideEmulation.js[module] = true
 
 [import_locales]
 adblockplus/chrome/locale/*/global.properties = subscription_invalid_location

(Only briefly tested, I would recommend testing further yourself.)

[kzar]

(Also take a look at #5089.)

[abpbot]

A commit referencing this issue has landed:
​Issue 5584 - Update adblockpluscore dependency to hg:217eff0504a

[Ross]

The element hiding parts of this ticket seems fine in Chrome/Opera/FirefoxWebEx, still looking at notification parts.

[Ross]

Element hiding fixes/changes are working as expected (except in older browsers - #5773). The notification features added appear to work as expected. Related issues (like #5000) are fixed.

ABP 1.13.3.1838
Chrome 52 / 61 / Windows 7/10
Opera 40 / 47 / Windows 7/10